debug: add support for stopDebugging api
#10638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit adds support for the `stopDebugging` vscode api. The api can accept a debug session, and if none are provided it will terminate all active sessions. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
added
vscode
colin-grant-work
approved these changes
Jan 13, 2022
alvsan09
approved these changes
Jan 14, 2022
kittaakos
reviewed
Jan 19, 2022
| } | ||
| // Terminate all sessions if no session is provided. | ||
| for (const session of this.sessionManager.sessions) { | ||
| this.sessionManager.terminateSession(session); |
There was a problem hiding this comment.
When $stopDebugging is called with a sessionId, the promise resolves when the session was terminated (or rejected). The promise might resolve earlier when calling the function without the sessionId arg. Maybe an await is missing from here.
Sorry for the noise if I am wrong 😊
5 tasks
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request adds support for the
stopDebuggingVS Code API.The API terminates the session if provided, else it will terminate all sessions.
How to test
theiaas a workspacerun mocha tests)Debug Test: Stop Active Session) - the session should terminaterun mocha testsmultiple times with different*.spec.tsfiles)Debug Test: Stop All Sessions) - all sessions should terminateReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]