Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z-index overlay issue in dock panels #14695

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Jan 6, 2025

What it does

Closes #14290

Phosphor.js automatically sets the z-index: 0 css property on all dock panel items and children of split panels. However, this prevents the monaco editor popups from actually popping up on top of other panel items, therefore being partially hidden.

I've tested the fix suggested in the issue and found no further bugs with it. Completion, hover and diagnostics all seem to work as expected without any unexpected side effects.

How to test

See issue #14290 for reproduction steps. Ensure that the popups are fully visible.

Review checklist

Reminder for reviewers

@msujew msujew added monaco issues related to monaco ui/ux issues related to user interface / user experience labels Jan 6, 2025
@msujew msujew requested review from tsmaeder and sgraband January 6, 2025 11:08
Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Tested it and it works great 🎉 I wasn't able to find any side effects as well.

@msujew msujew merged commit 9edbf2c into master Jan 7, 2025
11 checks passed
@msujew msujew deleted the msujew/dock-panel-overlay branch January 7, 2025 10:26
@github-actions github-actions bot added this to the 1.58.0 milestone Jan 7, 2025
@hannescmarits
Copy link

Great, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco issues related to monaco ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Editor popups get cut off outside of view
3 participants