Fix z-index overlay issue in dock panels #14695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #14290
Phosphor.js automatically sets the
z-index: 0
css property on all dock panel items and children of split panels. However, this prevents the monaco editor popups from actually popping up on top of other panel items, therefore being partially hidden.I've tested the fix suggested in the issue and found no further bugs with it. Completion, hover and diagnostics all seem to work as expected without any unexpected side effects.
How to test
See issue #14290 for reproduction steps. Ensure that the popups are fully visible.
Review checklist
Reminder for reviewers