[call-hierarchy] Implement proposed LSP extension (WIP) #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTugarev
commented
Jan 23, 2019
|
Can we (re-)use the
in the widgets? (Same for the type hierarchy UI;
|
Signed-off-by: Alex Tugarev <[email protected]>
AlexTugarev
force-pushed
the
at/call-hierarchy
branch
from
a60c08a to
eae09db
Compare
|
@kittaakos, I've updated the PR with latest changes to the protocol (proposed.) |
|
microsoft/vscode-languageserver-node#420 is merged! so back to square one an reimplement this :-) |
|
@AlexTugarev is this pull-request closeable thanks to #6924 ? |
|
'closing as rotten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the client side of the updated LSP proposal for a call hierarchy.
typescript-language-server: [call-hierarchy] Revised implementation of the proposed call hierarchy protocol (WIP) typescript-language-server/typescript-language-server#98textDocument/callHierarchyextension microsoft/vscode-languageserver-node#420WIP because the PR for
typescript-language-serverisn't merged yet.