test: [filesystem] Update nsfw to support Node 10.15.1 #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
requested review from
thegecko,
svenefftinge,
kittaakos and
marcdumais-work
|
I forgot to update the CI to use Node 10 too, but on my workstation it worked without any issue. |
paul-marechal
force-pushed
the
mp/node-10
branch
from
81a9752 to
b95242d
Compare
|
Update CI configs to run Node 10. |
|
I thought we do the Node.js 10.x support with electron 3.x. |
|
@kittaakos I don't know, just wanted to try and see what was failing, turns out it was pretty minimal. But it seems to make sense to do the Electron upgrade at the same time, this way both target will be in sync. If anything, this change can serve as a base for the actual migration from 8 to 10, unless this was already figured out, really no idea. In the mean time I am curious to see how the CI behaves on this patch. |
paul-marechal
changed the title
|
Turns out Travis failed... |
paul-marechal
removed request for
thegecko,
svenefftinge,
kittaakos and
marcdumais-work
Also updated CI configs to run Node 10. Signed-off-by: Paul Maréchal <[email protected]>
paul-marechal
force-pushed
the
mp/node-10
branch
from
b95242d to
eb45620
Compare
|
CI was building correctly. |
|
👍 Keep an eye on #3729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Maréchal [email protected]