Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4585: Fixed the selection state issue. #4597

Merged
merged 1 commit into from
Mar 19, 2019
Merged

GH-4585: Fixed the selection state issue. #4597

merged 1 commit into from
Mar 19, 2019

Conversation

kittaakos
Copy link
Contributor

From now on, the nodes are remapped from the tree,
to ensure the selection and focus represents the most recent state.
This fix ensures that the selection state does not get out of sync.

Closes #4585.

Signed-off-by: Akos Kitta [email protected]

From now on, the nodes are remapped from the `tree`,
to ensure the `selection` and `focus` represents the most recent state.
This fix ensures that the selection state does not get out of sync.

Closes #4585.

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos requested a review from akosyakov March 18, 2019 09:52
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested that multi-selection still works nicely 👍

@kittaakos kittaakos merged commit a7e50c0 into master Mar 19, 2019
@kittaakos kittaakos deleted the GH-4585 branch March 19, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tree] The tree selection state can go out of sync when reconciling the tree
2 participants