[Plugin-Api] Add stub implementation of the VsCode comment Plugin-Api #5118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Vinokur <[email protected]>
azatsarynnyy
approved these changes
May 11, 2019
15 tasks
|
hello, we want to avoid stubbing now in Theia. When is planned the full implementation that you're referencing at #5076 ? |
|
@benoitf Since Extend VsCode pull-request plugin (eclipse-che/che#10282) has the highest priority, we plan to start work on full implementation after eclipse-che/che#10282. This PR is needed to launch the VsCode pull-request plugin. |
|
@benoitf any updates? |
14 tasks
benoitf
approved these changes
Jun 27, 2019
|
@vparfonov What is ETA to bring the implementation? How stubbing helps? I doubt it makes extension usable for end users, but only introduce confusion but making APIs looks implemented. Did you really needed it to be merged in order to continue working on the implementation? |
8 tasks
This was referenced Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A stub implementation of the VsCode
commentPlugin-Api that returns a dummy object. A full implementation is going to be done in the scope of #5076Is needed for eclipse-che/che#11867