-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'reject-cycles' lerna option #5239
Conversation
@evidolob, perhaps you forgot to commit the actual fix. Is this in a WIP state? |
No, I think @vinokurig is working on providing fix. I just wont to make sure that problem with cyclic dependencies never appears again. |
I think we can all agree, we won't merge your PR without the fix :) |
Yes, of course |
@evidolob @kittaakos I am working on it right now |
@evidolob @kittaakos The Fix is ready, please review #5241 |
Can you please rebase from the |
Signed-off-by: Yevhen Vydolob <[email protected]>
872e55a
to
7f13a65
Compare
Done |
👍 Let's wait with the merge. See: #4279 (comment) |
Will the PR also pick this cyclic dependency? #4895 |
No. It checks npm package dependencies and cycles and not module dependencies. |
@kittaakos Hi, it seems that #5241 are merged, can you review this pull? |
@evidolob, AFAIK, @akosyakov will go through the SCM-related changes manually and will check what functionality and commits did we lose. I'd leave the decision up to him. |
@kittaakos OK, thx. @akosyakov Any objections to merge this pull? |
Could we enable it |
I try to add it in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thx
Now we have cyclic dependency problem
@theia/plugin-ext, @theia/scm depends on each other, and lerna provides this warning message:
Encountered a cycle in the dependency graph.This may cause instability! Packages in cycle are: "@theia/git", "@theia/plugin-ext-vscode", "@theia/plugin-ext", "@theia/scm", "@theia/example-browser", "@theia/example-electron"
This pull add
--reject-cycles
lerna option to fail build if any cyclic dependency exists