Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored LanguagesMainImpl and OutputChannelRegistryMainImpl so they could be extended #6148

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Refactored LanguagesMainImpl and OutputChannelRegistryMainImpl so they could be extended #6148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/plugin-ext/src/common/plugin-api-rpc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

/* tslint:disable:no-any */

import { createProxyIdentifier, ProxyIdentifier } from './rpc-protocol';
import { createProxyIdentifier, ProxyIdentifier, RPCProtocol } from './rpc-protocol';
import * as theia from '@theia/plugin';
import { PluginLifecycle, PluginModel, PluginMetadata, PluginPackage, IconUrl } from './plugin-protocol';
import { QueryParameters } from './env';
Expand Down Expand Up @@ -1141,6 +1141,16 @@ export interface LanguagesExt {
$resolveRenameLocation(handle: number, resource: UriComponents, position: Position, token: CancellationToken): PromiseLike<RenameLocation | undefined>;
}

export const LanguagesMainFactory = Symbol('LanguagesMainFactory');
export interface LanguagesMainFactory {
(proxy: RPCProtocol): LanguagesMain;
}

export const OutputChannelRegistryFactory = Symbol('OutputChannelRegistryFactory');
export interface OutputChannelRegistryFactory {
(): OutputChannelRegistryMain;
}

export interface LanguagesMain {
$getLanguages(): Promise<string[]>;
$changeLanguage(resource: UriComponents, languageId: string): Promise<void>;
Expand Down
1 change: 1 addition & 0 deletions packages/plugin-ext/src/common/rpc-protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export interface MessageConnection {
onMessage: Event<{}>;
}

export const RPCProtocol = Symbol('RPCProtocol');
export interface RPCProtocol {
/**
* Returns a proxy to an object addressable/named in the plugin process or in the main process.
Expand Down
Loading