[monaco] Fix bad preference initialization #6450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first register override identifier, because monaco will immediately
update already opened documents and then initialize with
bad preferences.
Fixes #6449
What it does
The plug-in initialization happens slightly after the editors have been created.
When a new language is registered, monaco will update the options of matching editors immediately.
But our preferenceService doesn't know yet about the override identifier and returns a bad preference model (undefined values).
This change registers the override identifier first.
How to test
Review checklist
Reminder for reviewers