-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mobile] Add meta viewport tag. #6967
Conversation
Co-Authored-By: Eric Rabil <[email protected]> Signed-off-by: Nisar Hassan Naqvi <[email protected]>
Hi @nisarhassan12, many thanks for catching this! The missing viewport tag is likely a root cause for many of the strange zooming problems we see on mobile. I will try to test this on my Pixel 3, and compare the UX with/without your fix. If this works as expected, it would be a big improvement for Theia's experience on mobile. 👍 |
btw we have similar settings on webviews copied from VS Code:
maybe something useful as well |
@nisarhassan12 please be sure to accept the Eclipse Contributor Agreement (ECA) so that we can accept the contribution :) |
Thanks @vince-fugnitto I have accepted the ECA 🙂 . |
I'll let @jankeromnes complete the review, I don't have an iPad (or large touch device) to test the pull-request against and I trust his judgement :) |
Ok. Thanks! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super-cool fix, many thanks @nisarhassan12! 💯
I think this doesn't change the behavior on larger screens, but on smaller screens like smartphones this is a revolution -- Theia goes from broken to usable.
Also this is recommended by Lighthouse as a best practice.
Before
Theia starts out very un-zoomed, and as soon as you tap anywhere, the browser zooms you in a lot on a specific spot, and doesn't allow you to control zoom or pan around (probably because we cancel touchmove events). This is almost not usable.
Now
Theia starts at a comfortable zoom level, where you can read and control almost the entire IDE. I agree it looks a bit awkward because it's so narrow, but I can use this already. Now we'll "just" need to fix other small usability issues, like resizing panels on mobile, and we'll have a productive coding environment on smartphones.
Also, thanks a lot @akosyakov and @vince-fugnitto for chiming in! 👍 |
And of course congratulations @nisarhassan12 on your first commit in Theia! 🎉🥇 |
Hi!
This Pr addresses the following from #3557