Show progress on plugin activation #7017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Jan 31, 2020
| @@ -185,7 +188,10 @@ export class PluginManagerExtImpl implements PluginManagerExt, PluginManager { | |||
| this.registry.set(plugin.model.id, plugin); | |||
| if (plugin.pluginPath && Array.isArray(plugin.rawModel.activationEvents)) { | |||
| const activation = async () => { | |||
| const title = `Loading ${plugin.model.displayName || plugin.model.name}`; | |||
| const id = await this.notificationMain.$startProgress({title, location: 'window'}); | |||
There was a problem hiding this comment.
please use Theia or VS Code that formatting on save works
akosyakov
reviewed
Jan 31, 2020
Fixes: 6550 Signed-off-by: Amiram Wingarten <[email protected]>
akosyakov
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6550
Signed-off-by: Amiram Wingarten [email protected]
What it does
Show progress loading message on theia shell status bar when vscode extension is activated. This can happen on activation event or on reconnects.
How to test
Review checklist
Reminder for reviewers