feat(plugins): Allow to customise the plugin-host process #7181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Off: Seems like the theia/packages/plugin-ext/src/hosted/node/hosted-plugin-process.ts Lines 34 to 35 in ef1f903 Is it a bug or we ignore linter issues on the CI? By the way, I did not see any linter issues in VS Code either. (CC: @marechal-p) |
It looks like a bug, I believe it should be the following: "no-multiple-empty-lines": ["error", { "max": 1 }],This means any other consecutive line (ex: 2 blank will fail). |
1 task
azatsarynnyy
approved these changes
Feb 19, 2020
16 tasks
Fixes eclipse-theia#7180 Change-Id: I6977e799a74238637c50ed7e6845c610c208ec02 Signed-off-by: Florent Benoit <[email protected]>
|
@kittaakos @vince-fugnitto the extra empty line has been removed |
|
FYI I will merge today with the approval I got. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Allow to configure through
inversifythe path of the process to be launched for plug-insFixes #7180
How to test
Launch Theia with plug-ins (or VS Code extensions)
They should work as usual (if process is not found BTW no plug-in can start)
Review checklist
Reminder for reviewers
Change-Id: I6977e799a74238637c50ed7e6845c610c208ec02
Signed-off-by: Florent Benoit [email protected]