[Electron] Don't stat for electron save dialog

[thegecko]

Signed-off-by: Rob Moran [email protected]

What it does

When using the fileDialogService.showSaveDialog() function in Electron, a messageService message is shown if the file input doesn't yet exist:

Cannot access resource at <file>.

This is because there is an explicit stat check for the file to see if it is readable/writable, but it's possible it doesn't yet exist.

This looks like it may be a copy-paste error from the OpenDialog(), but I can update this PR if the checks need to be kept for when the file already exists.

How to test

Using the electron version, save an existing file as a new file which doesn't exist and observe the message.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[kittaakos]

Nice catch, it is broken. But your fix is partial:

const uri = FileUri.create(filename);
const exists = await this.fileSystem.exists(uri.toString());
if (!exists) {
    resolve(uri);
    return;
}
const canAccess = await this.canReadWrite(uri);
resolve(canAccess ? uri : undefined);

And please fix the other bug in the showOpenDialog. Thoughts? Thanks!

[thegecko]

@kittaakos Sure I'll update the PR.

I don't think the open dialog is broken, though. I would expect the file to be opened would already need exist?

[kittaakos]

I don't think the open dialog is broken, though

It is, it resolves to a promise, but we never await. The this.canReadWrite(uris) condition will be always true. Please fix them together.

[thegecko]

Updated

[thegecko]

@kittaakos happy with this change?

[kittaakos]

I am trying it now...

[kittaakos]

Nice! 👍 It was completely broken. Thank you for the fix, @thegecko

[thegecko]

Thanks @kittaakos !