Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-7200: Made RecursivePartial array aware. #7201

Merged
merged 1 commit into from
Feb 25, 2020
Merged

GH-7200: Made RecursivePartial array aware. #7201

merged 1 commit into from
Feb 25, 2020

Conversation

kittaakos
Copy link
Contributor

Closes #7200.

Signed-off-by: Akos Kitta [email protected]

What it does

This PR patches the RecursivePartial type so that it gracefully handles nested array props.

How to test

Check the CI, it should be green.

Review checklist

Reminder for reviewers

@kittaakos kittaakos requested a review from akosyakov February 24, 2020 11:10
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine since build still compiles. Thank you!

@akosyakov akosyakov added the core issues related to the core of the application label Feb 25, 2020
@kittaakos kittaakos merged commit e5ab531 into master Feb 25, 2020
@kittaakos kittaakos deleted the GH-7200 branch February 25, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core issues related to the core of the application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RecursivePartial is not array aware.
2 participants