[editor] Show languages and focus file-tree while preview #7258
Conversation
Title: [editor] Show languages while preview This issue fixes the underlying problem where when a new file was opened in preview mode, the focus was on the previously active file and not on the navigator + the statusbar at the bottom was not updated. This PR collectively fixes both the issues. Signed-off-by: Muhammad Anas Shahid <[email protected]>
Anasshahidd21
changed the title
| @@ -93,6 +93,14 @@ export abstract class WidgetOpenHandler<W extends BaseWidget> implements OpenHan | |||
| await this.shell.activateWidget(widget.id); | |||
| } else if (op.mode === 'reveal') { | |||
| await this.shell.revealWidget(widget.id); | |||
| this.shell.currentChanged.emit({ | |||
There was a problem hiding this comment.
only shell can fire such events via the widget tracker
There was a problem hiding this comment.
Also it is bogus, revealing the widget does not change the focus and should not change the current widget
There was a problem hiding this comment.
Thank you for the review, do you have any suggestions as to how will we be able to fix this issue?
There was a problem hiding this comment.
Sorry, I still don't understand the issue: #7170 (comment). As I've mentioned already the editor preview should not be focused. It is correct.
There was a problem hiding this comment.
@akosyakov try to preview a file in VS Code, even though the focus is not set to the opened preview, the status bar will correctly show the current language and information for said editor.
Right now in Theia the status bar uses shell.currentWidget to get its information from, and it seems to be driven by the FocusTracker instance, except we are not sure if we should register preview editors with it?
There was a problem hiding this comment.
Understood, I don't think we can change the semantic of shell.currentWidget but I wonder whether we can build on top if a different semantic for a current widget of some kind: #7170 (comment)
What it does
Fixes: #7170 , #5027
This issue fixes the underlying problem where when a new file was opened
in preview mode, the focus was on the previously active file and not on
the navigator + the StatusBar at the bottom was not updated. This PR
collectively fixes both the issues.
Signed-off-by: Muhammad Anas Shahid [email protected]
How to test
Open Theia with any repository
Try to open a file with single click
Check to see if the languages on the status-bar is displayed
Check to see if the focus is still on the file-tree.
Review checklist
Reminder for reviewers