Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added meta tag to enable fullscreen experience on iOS devices #7663

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

koseduhemak
Copy link

@koseduhemak koseduhemak commented Apr 24, 2020

Signed-off-by: Maximilian Füsslin [email protected]

What it does

Added meta tag to allow fullscreen experience on iOS devices.
Fixes: #7607

How to test

Review checklist

Reminder for reviewers

@vince-fugnitto
Copy link
Member

@koseduhemak thank you for your first pull-request :)

Before it can be accepted, please make sure to properly sign the Eclipse Contributor Agreement (ECA) using the same email as your sign-off, it is the reason for the failed CI check.

@koseduhemak
Copy link
Author

Done. Signed the ECA. Travis seems to be failing - but I don‘t think the added meta tag is causing this issue...

@vince-fugnitto vince-fugnitto added the ipad issues related to iPad label Apr 24, 2020
@vince-fugnitto
Copy link
Member

Done. Signed the ECA. Travis seems to be failing - but I don‘t think the added meta tag is causing this issue...

I was able to restart CI for you :) it happens from time to time with new non-committees due to a Travis API authentication.

Copy link
Member

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This works really well -- I was able to add Theia to my iPad's home screen (using Safari), and the new "shortcut" now opens Theia in fullscreen mode by default. 👍

Many thanks @koseduhemak for this really cool iPad/iOS UX improvement, and congratulations on your first contribution to Theia! 🎉

@jankeromnes jankeromnes merged commit bea6be6 into eclipse-theia:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ipad issues related to iPad
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add meta tag to allow fullscreen view on IPad
3 participants