core: fix closing confirmation on Electron #8861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
added
bug
paul-marechal
requested review from
kittaakos,
vince-fugnitto and
colin-grant-work
paul-marechal
force-pushed
the
mp/electron-confirm-close
branch
from
d402e40 to
6db76ec
Compare
On Electron/Linux, doing `showMessageBoxSync` does not block the unloading process. This leads to the window closing despite the user asking to keep it open. Instead we'll prevent closing right way, ask for confirmation and finally close. Signed-off-by: Paul Maréchal <[email protected]>
paul-marechal
force-pushed
the
mp/electron-confirm-close
branch
from
6db76ec to
4d366e6
Compare
paul-marechal
force-pushed
the
mp/electron-confirm-close
branch
from
ff35622 to
4d366e6
Compare
vince-fugnitto
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
The changes work very well and it now respects the end-user's choice when attempting to close the application. I verified for both linux and macos, that the application:
- the application closes successfully when the user chooses
yesto quit. - the application remains open when the user chooses
no.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Electron/Linux, doing
showMessageBoxSyncdoes not block theunloading process. This leads to the window closing despite the user
asking to keep it open.
Instead we'll prevent closing right way, ask for confirmation and
finally close.
Signed-off-by: Paul Maréchal [email protected]
Closes #8186
How to test
core.confirmExitpreference onalways.no.Review checklist
Reminder for reviewers