Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to get back all Os's for testing + firestore #882

Closed
danielpeintner opened this issue Nov 29, 2022 · 4 comments · Fixed by #1121
Closed

Try to get back all Os's for testing + firestore #882

danielpeintner opened this issue Nov 29, 2022 · 4 comments · Fixed by #1121
Labels
binding-firestore Issues related to firestore protocol binding

Comments

@danielpeintner
Copy link
Member

    LGTM... just remember to have a tracking issue so that in the future we can restore the full checklist.

Originally posted by @relu91 in #878 (review)

@relu91 relu91 added the binding-firestore Issues related to firestore protocol binding label May 30, 2023
@JKRhb
Copy link
Member

JKRhb commented Oct 9, 2023

I suppose due to the removal of the firestore binding, this issue can be closed, right?

@danielpeintner
Copy link
Member Author

I suppose due to the removal of the firestore binding, this issue can be closed, right?

I don' think so. We used to have MacOS testing for our GHAs as well.
Question: Shall we bring them back? The downside is that our GHAs run longer.

What do people think? Is Ubuntu testing enough?

@JKRhb
Copy link
Member

JKRhb commented Oct 10, 2023

Oh, sorry, I think I slightly misread the title 😅 I just did a test run of the full CI pipeline, and apparently, macOS and Windows are still considerably slower than Linux (about six minutes for macOS and eight minutes for Windows).

Maybe we could adjust the workflows so that the full CI workflow is being run when a push to master occurs? I think at the moment, it only runs when triggered manually. However, as eight minutes is not as bad as it was before, I think, we could also consider bringing Windows and macOS back in general to have a greater platform coverage.

@danielpeintner
Copy link
Member Author

Note:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding-firestore Issues related to firestore protocol binding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants