-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: have CI for tests across all Os's (manual) while default CI ru… #878
chore: have CI for tests across all Os's (manual) while default CI ru… #878
Conversation
@JKRhb Sorry for pinging you again.
Have you seen such issues on your side? I am seeing it in this PR and also in #865 |
Oh, sorry, using that fictitious content type must have broken something :/ I'll look into it! |
Should be fixed in #879 now :) |
@@ -0,0 +1,78 @@ | |||
name: Full CI Pipeline | |||
|
|||
on: workflow_dispatch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could also let the full CI pipeline only run for changes on the main branch instead? This way it does not slow down progress in PRs but still uncovers OS-specific errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment the full test is not run automatically. Hence one needs to trigger it manually. When doing so once can usually select the branch it should run this action.. this is at least how I have been seeing this working.
Do you mean something else ?
Do you mean we should use on: [push]
only and remove pull_request
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean something else ?
Do you mean we should use on: [push] only and remove pull_request ?
Exactly, that is what I meant :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense in general! At the moment I would stick to manually triggering because we have issue with macos_latest
and windows_latest
which we need to solve first.
@relu91 any thoughts?
Note: firestore tests fail on ubuntu_latest also. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... just remember to have a tracking issue so that in the future we can restore the full checklist.
…ns on linux only
alternative for #865