Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: have CI for tests across all Os's (manual) while default CI ru… #878

Merged

Conversation

danielpeintner
Copy link
Member

…ns on linux only

alternative for #865

@danielpeintner
Copy link
Member Author

@JKRhb Sorry for pinging you again.

   1) CoAP server implementation
       should support TD Content-Format negotiation:
     Error: Unknown Content-Format: application/foobar

Have you seen such issues on your side?
https://github.com/eclipse/thingweb.node-wot/actions/runs/3530516899/jobs/5922593923#step:7:195

I am seeing it in this PR and also in #865
https://github.com/eclipse/thingweb.node-wot/actions/runs/3522562908/jobs/5928441681#step:7:195

@JKRhb
Copy link
Member

JKRhb commented Nov 24, 2022

Oh, sorry, using that fictitious content type must have broken something :/ I'll look into it!

@JKRhb
Copy link
Member

JKRhb commented Nov 24, 2022

Should be fixed in #879 now :)

@@ -0,0 +1,78 @@
name: Full CI Pipeline

on: workflow_dispatch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also let the full CI pipeline only run for changes on the main branch instead? This way it does not slow down progress in PRs but still uncovers OS-specific errors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment the full test is not run automatically. Hence one needs to trigger it manually. When doing so once can usually select the branch it should run this action.. this is at least how I have been seeing this working.

Do you mean something else ?
Do you mean we should use on: [push] only and remove pull_request ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean something else ?
Do you mean we should use on: [push] only and remove pull_request ?

Exactly, that is what I meant :)

Copy link
Member Author

@danielpeintner danielpeintner Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense in general! At the moment I would stick to manually triggering because we have issue with macos_latest and windows_latest which we need to solve first.
@relu91 any thoughts?

@danielpeintner
Copy link
Member Author

Note: firestore tests fail on ubuntu_latest also.
Hence, I will remove firestore from the test set.

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... just remember to have a tracking issue so that in the future we can restore the full checklist.

@danielpeintner danielpeintner merged commit 179ae76 into eclipse-thingweb:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants