Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: request new template repo #56

Conversation

paullatzelsperger
Copy link
Contributor

Description

Requesting a new template repository, which will serve as starting point for everyone who wants to create their
own variant (="distribution") of EDC.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@paullatzelsperger paullatzelsperger requested review from a team as code owners February 22, 2024 13:41
Copy link

This is your friendly self-service bot. The author (paullatzelsperger) of this PR is associated with this organization in the role of MEMBER.

Additionally, paullatzelsperger is a member of the following teams:

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@netomi
Copy link
Contributor

netomi commented Feb 26, 2024

/check-sync

This comment has been minimized.

@netomi netomi force-pushed the chore/request_new_template_repo branch from cb79916 to 453cc18 Compare February 26, 2024 20:24

This comment has been minimized.

This comment has been minimized.

@netomi netomi requested a review from Siegfriedk February 27, 2024 06:42
@netomi netomi force-pushed the chore/request_new_template_repo branch from 453cc18 to 8c00b75 Compare February 28, 2024 19:22

This comment has been minimized.

This comment has been minimized.

@Siegfriedk
Copy link
Contributor

@paullatzelsperger why the tractus-x prefix? tractus-x is already part of the org 'scope'

@paullatzelsperger
Copy link
Contributor Author

paullatzelsperger commented Feb 29, 2024

@paullatzelsperger why the tractus-x prefix? tractus-x is already part of the org 'scope'

the "origin" repo on which the template is based, is called tractux-edc, so it seemed reasonable to call this tractusx-edc-template to keep consistency.

@Siegfriedk
Copy link
Contributor

@paullatzelsperger i see. Makes sense, it would make sense to rename edc too, but probably too late for that.

@paullatzelsperger
Copy link
Contributor Author

@paullatzelsperger i see. Makes sense, it would make sense to rename edc too, but probably too late for that.

it probably is, and that could create even more confusion than we already have with "Tx-EDC vs (upstream) EDC"

@paullatzelsperger paullatzelsperger force-pushed the chore/request_new_template_repo branch from 8c00b75 to 17bdb98 Compare February 29, 2024 14:02

This comment has been minimized.

This comment has been minimized.

@netomi
Copy link
Contributor

netomi commented Feb 29, 2024

so is the change accepted?

Signed-off-by: Thomas Neidhart <[email protected]>
Copy link

This is your friendly self-service bot.
Please find below the validation of the requested configuration changes:

Diff for 0d69a09
Organization automotive.tractusx[id=eclipse-tractusx]
  there have been 42 validation infos, enable verbose output with '-v' to to display them.

+  add repository[name="tractusx-edc-template"] {
+    allow_auto_merge                  = false
+    allow_forking                     = true
+    allow_merge_commit                = false
+    allow_rebase_merge                = true
+    allow_squash_merge                = true
+    allow_update_branch               = true
+    archived                          = false
+    default_branch                    = "main"
+    delete_branch_on_merge            = false
+    dependabot_alerts_enabled         = true
+    dependabot_security_updates_enabled = false
+    description                       = null
+    gh_pages_build_type               = "disabled"
+    has_discussions                   = false
+    has_issues                        = true
+    has_projects                      = true
+    has_wiki                          = true
+    homepage                          = null
+    is_template                       = true
+    merge_commit_message              = "PR_TITLE"
+    merge_commit_title                = "MERGE_MESSAGE"
+    name                              = "tractusx-edc-template"
+    private                           = false
+    secret_scanning                   = "enabled"
+    secret_scanning_push_protection   = "enabled"
+    squash_merge_commit_message       = "COMMIT_MESSAGES"
+    squash_merge_commit_title         = "COMMIT_OR_PR_TITLE"
+    template_repository               = null
+    topics                            = []
+    web_commit_signoff_required       = true
+  }

+  add repo_workflow_settings[repository="tractusx-edc-template"] {
+    actions_can_approve_pull_request_reviews = true
+    default_workflow_permissions      = "read"
+    enabled                           = true
+  }

+  add branch_protection_rule[pattern="main", repository="tractusx-edc-template"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    bypass_pull_request_allowances    = []
+    dismisses_stale_reviews           = false
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "main"
+    require_last_push_approval        = false
+    required_approving_review_count   = "1"
+    requires_code_owner_reviews       = false
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = false
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = true
+    requires_status_checks            = false
+    restricts_pushes                  = false
+    restricts_review_dismissals       = false
+  }
  
  Plan: 3 to add, 0 to change, 0 to delete.

Add a comment /help to get a list of available commands.

Copy link

This is your friendly self-service bot. The current configuration is in-sync with the live settings. 🚀

@paullatzelsperger
Copy link
Contributor Author

@Siegfriedk @netomi is there anything left to do or can we merge this?

@Siegfriedk
Copy link
Contributor

Nothing to do from my side, i gave thumbs up already

@netomi
Copy link
Contributor

netomi commented Mar 1, 2024

ok so the thumbs up does not trigger a notification.

@netomi netomi merged commit 097d058 into eclipse-tractusx:main Mar 1, 2024
4 checks passed
Copy link

This is your friendly self-service bot.

The following changes have been successfully applied:

Organization automotive.tractusx[id=eclipse-tractusx]
  there have been 42 validation infos, enable verbose output with '-v' to to display them.

+  add repository[name="tractusx-edc-template"] {
+    allow_auto_merge                  = false
+    allow_forking                     = true
+    allow_merge_commit                = false
+    allow_rebase_merge                = true
+    allow_squash_merge                = true
+    allow_update_branch               = true
+    archived                          = false
+    default_branch                    = "main"
+    delete_branch_on_merge            = false
+    dependabot_alerts_enabled         = true
+    dependabot_security_updates_enabled = false
+    description                       = null
+    gh_pages_build_type               = "disabled"
+    has_discussions                   = false
+    has_issues                        = true
+    has_projects                      = true
+    has_wiki                          = true
+    homepage                          = null
+    is_template                       = true
+    merge_commit_message              = "PR_TITLE"
+    merge_commit_title                = "MERGE_MESSAGE"
+    name                              = "tractusx-edc-template"
+    private                           = false
+    secret_scanning                   = "enabled"
+    secret_scanning_push_protection   = "enabled"
+    squash_merge_commit_message       = "COMMIT_MESSAGES"
+    squash_merge_commit_title         = "COMMIT_OR_PR_TITLE"
+    template_repository               = null
+    topics                            = []
+    web_commit_signoff_required       = true
+  }

+  add repo_workflow_settings[repository="tractusx-edc-template"] {
+    actions_can_approve_pull_request_reviews = true
+    default_workflow_permissions      = "read"
+    enabled                           = true
+  }

+  add branch_protection_rule[pattern="main", repository="tractusx-edc-template"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    bypass_pull_request_allowances    = []
+    dismisses_stale_reviews           = false
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "main"
+    require_last_push_approval        = false
+    required_approving_review_count   = "1"
+    requires_code_owner_reviews       = false
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = false
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = true
+    requires_status_checks            = false
+    restricts_pushes                  = false
+    restricts_review_dismissals       = false
+  }

  
  Applying changes:


  Done.
  
  Executed plan: 3 added, 0 changed, 0 deleted.

@paullatzelsperger paullatzelsperger deleted the chore/request_new_template_repo branch March 4, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants