Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add wait time after test Postgres startup for colima users #1239

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Feb 20, 2025

Description

This pull request introduces a wait time after the Postgres test container startup to make sure that the exposed ports are actually now reachable on localhost.

This solves an issue for colima users, as lima may take a few seconds to make exported ports available as discussed here: abiosoft/colima#71

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nicoprow nicoprow requested a review from SujitMBRDI February 20, 2025 08:21
@nicoprow nicoprow marked this pull request as ready for review February 20, 2025 08:21
@nicoprow nicoprow added this to the BPDM v6.3.0 / R25.03. milestone Feb 20, 2025
@nicoprow nicoprow added the enhancement New feature or request label Feb 20, 2025
@nicoprow nicoprow merged commit 83f1260 into main Feb 20, 2025
17 checks passed
@nicoprow nicoprow deleted the test/colima-wait-fix branch February 20, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants