-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: QGate preparations #46
chore: QGate preparations #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general!
Just another thing which came into my mind regarding this TRG
https://eclipse-tractusx.github.io/docs/release/trg-5/trg-5-01
You might want to look into setting that default value https://github.com/paullatzelsperger/bpn-did-resolution-service/blob/chore/qgate_preparations/system-tests/helm/values-test.yaml#L25, otherwise this might not be compliant, just pointing it out.
You might want to look into setting that default value https://github.com/paullatzelsperger/bpn-did-resolution-service/blob/chore/qgate_preparations/system-tests/helm/values-test.yaml#L25, otherwise this might not be compliant, just pointing it out.
I don't think that is a good idea, as it will lead to bogus trusted issuers by default (a topic we've had problems with in the past), and thus purposefully lead users on a wrong path. Providing dummy default values, that won't work anyway, does more harm than good. |
WHAT
Adds missing pieces for QGate evaluation
WHY
I ask myself that question daily.
FURTHER NOTES
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Relates to eclipse-tractusx/sig-release#689