chore: add example resource limits for postgres configuration #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the resource defs can't be commented out (TRG 5.04) |
lgblaumeiser
force-pushed
the
chore/improve_chart
branch
from
8f2d8f7 to
1cc5ac7
Compare
lgblaumeiser
changed the title
|
Right, the TRG is quite explicit here, I'll add them as defaults |
lgblaumeiser
force-pushed
the
chore/improve_chart
branch
from
1cc5ac7 to
7772418
Compare
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
lgblaumeiser
force-pushed
the
chore/improve_chart
branch
from
7772418 to
f0b4be6
Compare
|
Hi @paullatzelsperger , should meet requirements from TRG 5.04 now. |
paullatzelsperger
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Previously the postgresql deployment in the helm charts does not state any resource constraints and relies on the constraints of the referred charts. Proposed solution is to add an example resource constraint.
WHY
During deployment in a test environment, it took a while to figure out, how the resource constraint have to be defined. By providing a commented example for setting the constraints, an adopter does not have to research for the right configuration but can simply uncomment or copy the proposal and adapt it accordingly.
FURTHER NOTES
n/a
Closes #80