-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: DCM KIT additional content E2E test #1137
doc: DCM KIT additional content E2E test #1137
Conversation
…w template and improve readability
…hub.com/ClosedSourcerer/eclipse-tractusx.github.io into R25.03]-DCM-Additional-Content-E2E-Test
…template to improve readability
Create valid WeekBasedCapacityGroup Create invalid WeekBasedCapacityGroup Create valid WeekBasedMaterialDemand Create invalid WeekBasedMaterialDemand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR ⇾ Built it locally ⇾ worked fine
TBH, I am unable to review it on a business level
The DEPENDENCIES file would need an update, and I think we have to create an IP issue for this number of changes.
thx
Review on a BusinessLevel will be executed by the DCM Expert Group
I created the IP Issue and linked it in the PRs initial comment. Obviously I do not fully grasp the whole DEPENDENCIES issue yet. What am I missing? |
Cool, thanks. Let's have a short call related to DEPENDENCIES. Here are some hints, what kind of issues there might be:
Solution (for me, what I commit with checking the checkbox (DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.) ⇾ i always run the dash tool locally with this command (root of repository): java -jar org.eclipse.dash.licenses-1.1.0.jar package-lock.json -project automotive.tractusx -summary ./DEPENDENCIES -review -token your-gitlab-token This checks for new updates and updates the DEPENDENCIES file and also creates automatically a new issue if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of the core group, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ClosedSourcerer LGTM, you can merge it. THX
thanks for the work |
Description
Addresse Issues
Added
Changed
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: