Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: DCM KIT additional content E2E test #1137

Conversation

ClosedSourcerer
Copy link
Contributor

@ClosedSourcerer ClosedSourcerer commented Jan 29, 2025

Description

Addresse Issues

Added

Changed

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

ClosedSourcerer and others added 26 commits November 28, 2024 12:10
Create valid WeekBasedCapacityGroup
Create invalid WeekBasedCapacityGroup
Create valid WeekBasedMaterialDemand
Create invalid WeekBasedMaterialDemand
@ClosedSourcerer ClosedSourcerer added the documentation Improvements or additions to documentation label Jan 29, 2025
@ClosedSourcerer ClosedSourcerer requested review from stephanbcbauer and a team January 29, 2025 14:04
Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR ⇾ Built it locally ⇾ worked fine
TBH, I am unable to review it on a business level

The DEPENDENCIES file would need an update, and I think we have to create an IP issue for this number of changes.

thx

@ClosedSourcerer
Copy link
Contributor Author

Thanks for this PR ⇾ Built it locally ⇾ worked fine TBH, I am unable to review it on a business level

Review on a BusinessLevel will be executed by the DCM Expert Group

The DEPENDENCIES file would need an update, and I think we have to create an IP issue for this number of changes.

I created the IP Issue and linked it in the PRs initial comment.

Obviously I do not fully grasp the whole DEPENDENCIES issue yet.
This PR only changes existing markdown files and does not introduce package Ingestion anywhere.
So, assuming that up-to-date DEPENDENCIES are a requirement before merging, the base this PR is build upon should be fine and hence the whole PR as well.

What am I missing?

@stephanbcbauer
Copy link
Member

Thanks for this PR ⇾ Built it locally ⇾ worked fine TBH, I am unable to review it on a business level

Review on a BusinessLevel will be executed by the DCM Expert Group

The DEPENDENCIES file would need an update, and I think we have to create an IP issue for this number of changes.

I created the IP Issue and linked it in the PRs initial comment.

Obviously I do not fully grasp the whole DEPENDENCIES issue yet. This PR only changes existing markdown files and does not introduce package Ingestion anywhere. So, assuming that up-to-date DEPENDENCIES are a requirement before merging, the base this PR is build upon should be fine and hence the whole PR as well.

What am I missing?

Cool, thanks. Let's have a short call related to DEPENDENCIES. Here are some hints, what kind of issues there might be:

  1. DEPENDENCIES files is not up-to-date. ⇾ There might be changes in the master data ⇾ new libs, versions, status ⇾ Solution: rebase (if someone else already updated the file)
  2. New versions libs are used or haven't been analysed by eclipse -> Third Party issue is needed

Solution (for me, what I commit with checking the checkbox (DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.) ⇾ i always run the dash tool locally with this command (root of repository):

java -jar org.eclipse.dash.licenses-1.1.0.jar package-lock.json -project automotive.tractusx -summary ./DEPENDENCIES -review -token your-gitlab-token

This checks for new updates and updates the DEPENDENCIES file and also creates automatically a new issue if needed.

@LukasSchmetz LukasSchmetz self-requested a review February 7, 2025 08:55
Copy link
Contributor

@LukasSchmetz LukasSchmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of the core group, LGTM

Copy link
Contributor

@reginePrivat reginePrivat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your work

Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ClosedSourcerer LGTM, you can merge it. THX

@FlorianKretschmer
Copy link

thanks for the work

@ClosedSourcerer ClosedSourcerer merged commit d13e448 into eclipse-tractusx:main Feb 14, 2025
5 checks passed
@ClosedSourcerer ClosedSourcerer deleted the R25.03]-DCM-Additional-Content-E2E-Test branch February 14, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants