Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logistics use case kit #1154

Merged
merged 64 commits into from
Feb 20, 2025
Merged

Add logistics use case kit #1154

merged 64 commits into from
Feb 20, 2025

Conversation

Grand-Thibault
Copy link
Contributor

@Grand-Thibault Grand-Thibault commented Feb 12, 2025 •
edited by stephanbcbauer
Loading

Description

  • Introduction of a new KIT for Logistics & Customs

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Grand-Thibault and others added 30 commits October 10, 2024 16:16
@Grand-Thibault
created folder structure for Logistics Kit
317930b
@Grand-Thibault
Merge pull request #1 from Grand-Thibault/create-logistics-kit-folder…
ec0a9a1 
…-structure

created folder structure for Logistics Kit
@Grand-Thibault
added Logistics Kit to sidebar
531bd53
@Grand-Thibault
fixed indentation for DCM
f735f5f
@Grand-Thibault
sorted top bar nav alphabetically and added Logistics
8e958e3
@Grand-Thibault
fixed wrong link to Logistics
4c47a82
@Grand-Thibault
added Logistics KIT to gallery
e9086c5
@Grand-Thibault
added logistics kit banner
7f3d3bd
@klanir123
Update page_adoption-view.md
c711527
@stephanbcbauer
Merge branch 'eclipse-tractusx:main' into add-logistics-kit
5852016
@Grand-Thibault
(doc) updated logistics logo to newest version, added license files
14d3cfd
@Grand-Thibault
(chore) fixed linting issues
09a492d
@Grand-Thibault
(doc) fixed wrong link
83b6712
@Grand-Thibault
(doc) removed <>
4174cce
@corinastolz
reviewed to line 33
d7d900d
@corinastolz
review line 48
5af6394
@corinastolz
review line 49
f17cd2c
@klanir123
Link at image inserted
98f8c0c
@klanir123
Create LogisticTwins.png
013337e
@klanir123
Add files via upload
9547b5c
@klanir123
Delete docs-kits/kits/Logistics Kit/asset directory
f1b4309
@klanir123
Create assets
6506b3f
@klanir123
Delete docs-kits/kits/Logistics Kit/assets
0d9044f
@klanir123
Create LogisticTwins.png
bb2ae1b
@klanir123
Add files via upload
d43aa05
@klanir123
bugfix
f8c219d
@klanir123
bugfix
9531aaa
@jSchuetz88
Create page_changelog.md
e62e2d6
@corinastolz
changes to line 56
fdb414b
@corinastolz
changes to line 97
f4fbc3b
Grand-Thibault
Grand-Thibault commented Feb 14, 2025
View reviewed changes
Copy link
Contributor Author

@Grand-Thibault Grand-Thibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed DCM part in sidebarDocsKits

stephanbcbauer
stephanbcbauer requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor change to be consistence. Thx

docs-kits/kits/logistics-kit/assets/LogisticTwins.png.license Outdated

- SPDX-License-Identifier: CC-BY-4.0
- SPDX-FileCopyrightText: 2024 Contributors to the Eclipse Foundation
- Source URL: https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/docs-kits/kits/Logistics Kit/assets/LogisticTwins.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since you renamed the folder, also these URLs need to be renamed. Also LogisticTwins.png should be logistic-twins.png

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jSchuetz88 jSchuetz88 self-requested a review February 18, 2025 20:20
Grand-Thibault
Grand-Thibault commented Feb 19, 2025
View reviewed changes
Copy link
Contributor Author

@Grand-Thibault Grand-Thibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

docs-kits/kits/logistics-kit/assets/LogisticTwins.png.license Outdated

- SPDX-License-Identifier: CC-BY-4.0
- SPDX-FileCopyrightText: 2024 Contributors to the Eclipse Foundation
- Source URL: https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/docs-kits/kits/Logistics Kit/assets/LogisticTwins.png
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

stephanbcbauer
stephanbcbauer approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -> Thx @Grand-Thibault

@stephanbcbauer stephanbcbauer merged commit 0dbc654 into eclipse-tractusx:main Feb 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanbcbauer stephanbcbauer stephanbcbauer approved these changes

@jSchuetz88 jSchuetz88 Awaiting requested review from jSchuetz88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Grand-Thibault @stephanbcbauer @klanir123 @corinastolz @jSchuetz88