-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable markdown linter for kits #674
feat: enable markdown linter for kits #674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I think it is the best option to merge it, even with failing check. These issues did pile up due to the lack of linting and should now be worked on collectively.
Separate issues per KIT would be fine in my opinion.
Looks like all open PRs are now failing due to this new rule. How to handle this? Should we inform now the responsible of every KIT to resolve their issues? |
I don't have fundamental problems with merging despite a failed linter check. But there should be a requirement that every update to every kit fixes THEIR issues for ALL releases. |
Exactly, @maximilianong! Every KIT has to fix its linting errors. @SebastianBezold and I are planning to create a GitHub Issue for every KIT. It is important that this will be checked during the Quality Gates.
The first part is correct, @arnoweiss: While the KIT developers are fixing their linting problems, merging with a failed pipeline is okay. For the second part: Since the current pipeline only checks the |
Description
This PR enables the markdown linter for the KITs.
Fixes #673
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: