Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update roles and rights #373

Merged
merged 1 commit into from
Jul 30, 2024
Merged

docs: update roles and rights #373

merged 1 commit into from
Jul 30, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jul 30, 2024

Description

Update the roles and rights images

Why

To show the latest version of the roles and rights concept

Issue

N/A

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have added copyright and license headers, footers (for .md files) or files (for images)
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 requested a review from evegufy July 30, 2024 10:20
Copy link

@evegufy evegufy requested a review from oyo July 30, 2024 10:56
@evegufy
Copy link
Contributor

evegufy commented Jul 30, 2024

@oyo do you want to review as well? you mentioned some special consideration for big images.

Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nice small filesize now

@Phil91 Phil91 merged commit a8dc306 into main Jul 30, 2024
8 checks passed
@Phil91 Phil91 deleted the feature/159-rr-md branch July 30, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants