Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SD Factory): Integrate the Tagus for SD Factory #1278

Conversation

tfjanjua
Copy link
Contributor

@tfjanjua tfjanjua commented Feb 14, 2025

Description

Integration of Gaia-X Tagus release (v2) in company onboarding SD Factory.

Why

v1 will be retired as of March 2025. Any API v1 calls will fail with a 400 HTTP Status Code.

Issue

Ref: #1274

Respective SD Factory Updates

eclipse-tractusx/sd-factory#221

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@tfjanjua tfjanjua self-assigned this Feb 14, 2025
@tfjanjua tfjanjua added the enhancement New feature or request label Feb 14, 2025
@tfjanjua
Copy link
Contributor Author

@evegufy | @Phil91 | @ntruchsess
I have tested changes on my local but clearing house (compliance) cannot access my local as clearing house (compliance) calls callback url to tell us the results (along with selfDescriptionDocument) but I wanted to test the callback url call also so, I will ask our DevOps to deploy this change on one of our envs. so I could test if clearing house (compliance) is also able to call callback url and we are also receiving the results and processing it also ... then I will mark this checkbox I have successfully tested my changes locally but changes can be reviewed in general.

@tfjanjua tfjanjua marked this pull request as ready for review February 17, 2025 08:06
@ntruchsess ntruchsess self-assigned this Feb 18, 2025
@ntruchsess ntruchsess added this to the Release 25.06 milestone Feb 18, 2025
@ntruchsess ntruchsess linked an issue Feb 18, 2025 that may be closed by this pull request
2 tasks
Copy link
Contributor

@ntruchsess ntruchsess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tfjanjua coding looks fine. We can merge this PR once you confirm successful testing on your deployment.

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to the release branch for 25.03 (-i, drop...) AFAIK this change should be still part of 25.03, right?

@MaximilianHauer
Copy link

this topic needs to be part of 25.03 as we otherwise are not able to communicate with the interfaces of the sd factory anymore due to their update to Tagus release

@typecastcloud typecastcloud force-pushed the feat/gaia-x-tagus-sd-factory branch from b7b8b2f to 499908b Compare February 19, 2025 09:27
@typecastcloud typecastcloud changed the base branch from main to release/v2.4.0-RC2 February 19, 2025 09:28
@typecastcloud
Copy link
Contributor

Hi @tfjanjua, I rebased this and changed to 25.03 milestone.

As soon as we get new clientid/secret it should be in test scope too.

@evegufy
Copy link
Contributor

evegufy commented Feb 19, 2025

@ntruchsess could you please have look again and approve?

@ntruchsess
Copy link
Contributor

ntruchsess commented Feb 19, 2025

@tfjanjua @typecastcloud : please confirm the test on your deployment was successful - then we can merge this PR ('I have successfully tested my changes locally' is not yet marked)

@tfjanjua
Copy link
Contributor Author

@tfjanjua @typecastcloud : please confirm the test on your deployment was successful - then we can merge this PR ('I have successfully tested my changes locally' is not yet marked)

Hi @ntruchsess , Yes we are on it and we have tried and this new request from portal-backend to SD Factory is failing at the moment.

.w.s.m.s.DefaultHandlerExceptionResolver : Resolved [org.springframework.http.converter.HttpMessageNotReadableException: JSON parse error: Unrecognized field "name" (class org.eclipse.tractusx.selfdescriptionfactory.model.vrel3.LegalParticipantSchema), not marked as ignorable]

We will discuss this issue T-Systems tomorrow and will update here.

@typecastcloud
Copy link
Contributor

typecastcloud commented Feb 19, 2025

@tfjanjua @typecastcloud : please confirm the test on your deployment was successful - then we can merge this PR ('I have successfully tested my changes locally' is not yet marked)

Hi @ntruchsess , Yes we are on it and we have tried and this new request from portal-backend to SD Factory is failing at the moment.

.w.s.m.s.DefaultHandlerExceptionResolver : Resolved [org.springframework.http.converter.HttpMessageNotReadableException: JSON parse error: Unrecognized field "name" (class org.eclipse.tractusx.selfdescriptionfactory.model.vrel3.LegalParticipantSchema), not marked as ignorable]

We will discuss this issue T-Systems tomorrow and will update here.

I opened an issue in SD-Factory repo:
eclipse-tractusx/sd-factory#231

Not sure yet where the issue comes from.

edit: this issue is resolved

@tfjanjua
Copy link
Contributor Author

tfjanjua commented Feb 20, 2025

@ntruchsess We have completed the testing and received successful response from SD Factory and generated SD Document for a company in portal.

I have check marked the I have successfully tested my changes locally

cc: @evegufy

@evegufy evegufy merged commit 91fbede into eclipse-tractusx:release/v2.4.0-RC2 Feb 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

SD Factory | Integrate the Gaia-X Tagus version Changes
5 participants