-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SD Factory): Integrate the Tagus for SD Factory #1278
feat(SD Factory): Integrate the Tagus for SD Factory #1278
Conversation
@evegufy | @Phil91 | @ntruchsess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tfjanjua coding looks fine. We can merge this PR once you confirm successful testing on your deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase to the release branch for 25.03 (-i, drop...) AFAIK this change should be still part of 25.03, right?
this topic needs to be part of 25.03 as we otherwise are not able to communicate with the interfaces of the sd factory anymore due to their update to Tagus release |
b7b8b2f
to
499908b
Compare
|
Hi @tfjanjua, I rebased this and changed to 25.03 milestone. As soon as we get new clientid/secret it should be in test scope too. |
@ntruchsess could you please have look again and approve? |
@tfjanjua @typecastcloud : please confirm the test on your deployment was successful - then we can merge this PR ('I have successfully tested my changes locally' is not yet marked) |
Hi @ntruchsess , Yes we are on it and we have tried and this new request from portal-backend to SD Factory is failing at the moment. .w.s.m.s.DefaultHandlerExceptionResolver : Resolved [org.springframework.http.converter.HttpMessageNotReadableException: JSON parse error: Unrecognized field "name" (class org.eclipse.tractusx.selfdescriptionfactory.model.vrel3.LegalParticipantSchema), not marked as ignorable] We will discuss this issue T-Systems tomorrow and will update here. |
I opened an issue in SD-Factory repo: Not sure yet where the issue comes from. edit: this issue is resolved |
@ntruchsess We have completed the testing and received successful response from SD Factory and generated SD Document for a company in portal. I have check marked the cc: @evegufy |
Description
Integration of Gaia-X Tagus release (v2) in company onboarding SD Factory.
Why
v1 will be retired as of March 2025. Any API v1 calls will fail with a 400 HTTP Status Code.
Issue
Ref: #1274
Respective SD Factory Updates
eclipse-tractusx/sd-factory#221
Checklist