Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig#810: Manage Company Data UI #623

Closed
jjeroch opened this issue Mar 19, 2024 · 7 comments
Closed

sig#810: Manage Company Data UI #623

jjeroch opened this issue Mar 19, 2024 · 7 comments
Assignees
Labels
Sub-task A small piece of work that's part of a larger task.
Milestone

Comments

@jjeroch
Copy link
Contributor

jjeroch commented Mar 19, 2024

Ticket Under Creation

Summary:

Implement a new feature in the existing application that allows users with the appropriate permissions to manage company data. This includes viewing and managing legal entity data, subsidiaries, company locations (BPNSs), and specific addresses (BPNAs).

Details:

Figma:
https://www.figma.com/file/olKk06eVXHIOZUtrcQbgcB/UX?type=design&node-id=3871-4&mode=design&t=PhBMDkTbkDIfmcod-0

Image

  1. User Authentication:

    • Ensure that only users with the necessary rights can access the data management panel.
    • Permission: company_data (note not yet existing - working on it)
  2. Data Management Panel Integration:

    • Integrate the new panel into the existing application seamlessly.
    • The panel should be accessible via a clear and intuitive navigation path.
  3. View Records:

    • Users should be able to view a list of legal entities, subsidiaries, BPNSs, and BPNAs.
  4. Add New Records:

    • Users should be able to add new legal entities, subsidiaries, BPNSs, and BPNAs.
    • Ensure that the addition of new records is user-friendly and validated client-side before submission.
  5. Edit Records:

    • Users should be able to edit existing legal entities, subsidiaries, BPNSs, and BPNAs.
    • Ensure that edits are validated client-side before submission.
  6. Delete Records:

    • Users should be able to delete existing legal entities, subsidiaries, BPNSs, and BPNAs with proper confirmation prompts to prevent accidental deletions.
  7. Workflow Integration:

    • Implement a workflow for record changes with the statuses: Pending, Error, and Active.
    • New entries and changes submitted should initially be marked as "Pending" and go through a validation process.
  8. Validation Process:

    • After submission, the entry should remain "Pending" until the validation process is complete.
    • If validation is successful, the status should change to "Active".
    • If validation fails, the status should be set to "Error", and the user should be able to view and correct the errors.
  9. Error Handling:

    • Users should be able to refresh the screen to view any possible errors.
    • Provide clear and informative error messages to guide the user through the necessary steps to correct the data.
  10. Backend Integration:

    • Prepare the frontend to connect with the BPDM interfaces for data handling.
    • Ensure that the frontend handles asynchronous operations and displays loading states appropriately.
  11. UI/UX:

    • Design a clean and modern user interface consistent with the existing application's design language.
    • Ensure that the UI is responsive and accessible across different devices and browsers.

Technical Notes:

  • The frontend should be implemented using the existing tech stack of the application.
  • Ensure that the code follows best practices for security, performance, and maintainability.

Dependencies:

  • Backend endpoints for BPDM interfaces are not yet existing - will get provided by BPDM asap
  • UI/UX design under finalization

Please ensure that all the acceptance criteria are met before submitting the task for review. If there are any blockers or clarifications needed, reach out to the project manager or team lead as soon as possible.

@jjeroch jjeroch added the Sub-task A small piece of work that's part of a larger task. label Mar 19, 2024
@jjeroch jjeroch added this to Portal Mar 19, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Mar 19, 2024
@jjeroch jjeroch removed their assignment Apr 16, 2024
@jjeroch jjeroch moved this from NEW USER REQUEST to BACKLOG in Portal Apr 16, 2024
@jjeroch
Copy link
Contributor Author

jjeroch commented Apr 16, 2024

@manojava-gk api endpoints not yet available. Please check if we can start based on the UX wireframes using shared components for realization

@manojava-gk
Copy link
Contributor

@jjeroch could you pls recheck about the delete function?

@msinamci msinamci moved this from BACKLOG to IN PROGRESS in Portal Apr 18, 2024
@jjeroch
Copy link
Contributor Author

jjeroch commented Apr 21, 2024

Updates ongoing this week to add all endpoint details - first description added below

@manojava-gk tackling the API connection
Attached the postman collection
BPDM Tests.postman_collection.json

View Records
Call all the records (note this call includes pagination)
Call GET {portal gate url*}/v6/input/business-partners/search?page=0&size=30
*please check with Evelyn...must be the same as we are using for PUSH/PULL process step of the registration approval process

Inside the body send an empty string

[ "" ]


Create Site
Create a new Site
Call POST ???

  • Users BPNL to be added inside legalEntityBpn
  • Add site.siteName
  • isOwnCompanyData to be set to ‚true‘
  • addressType to be set to ‚SiteMainAddress‘

@jjeroch
Copy link
Contributor Author

jjeroch commented May 7, 2024

Target Release updated, we wont make 24.05. in time - we are planning an interim release version in June

@evegufy
Copy link
Contributor

evegufy commented Sep 10, 2024

@MaximilianHauer I suggest to close this issue

@MaximilianHauer
Copy link

MaximilianHauer commented Sep 10, 2024

@manojava-gk what was the decision on the delete ? i assume there is no delete endpoint ? couldnt find any in the bpdm swagger

overall tested and approved

@github-project-automation github-project-automation bot moved this from IN REVIEW to USER READY in Portal Sep 10, 2024
@manojava-gk
Copy link
Contributor

delete is not available @MaximilianHauer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sub-task A small piece of work that's part of a larger task.
Projects
Archived in project
Development

No branches or pull requests

4 participants