-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app release process): enhance add technical user process #1401
Conversation
…rocess technical integration step
…elease process technical integration step
src/components/shared/basic/ReleaseProcess/OfferTechnicalIntegration/index.tsx
Show resolved
Hide resolved
searchPlaceholder={''} | ||
columnHeadersBackgroundColor={'#FFFFFF'} | ||
searchDebounce={1000} | ||
noRowsMsg={'No tech user added'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use translations instead of hardcoded text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me.
@saadanzari @Cofinity-UX would you also like to review? |
@evegufy yes, I'd like to review, thanks for looping me in! |
Hi @manojava-gk, 1. Copywriting for headline: 2. Copywriting for subline 3. Inputfiel label wording improvement 4. Placeholder text improvement 5. Technical user option should not be initially pre-seclected 6. Display 'External technical user' first 7. Harmonize font sizes 8. Disabled/inactive text should be styled completely as disabled 9. Checkbox for External technical user option ![]() |
Hi @Cofinity-UX you are looking at a different screen here. This PR is about technical integration step in app/service release process. The screen that you have shared here is from Technical User page. Will address the points which are valid in the current PR ![]() ![]() Here is the detailed response,
|
@manojava-gk ah, alright, thank you for the clarification! |
|
@oyo Any review comments for this? |
Description
enhance user experience by providing table and overlay in add technical user flow. List current users in the table. Allow user to edit the list in an overlay implementation
Chnagelog
Technical Integration - App and Service Release Process
- enhance user experience by providing table and overlay in add technical user flow. list current users in the table. allow user to edit the list in an overlay implementation [#1401]
Why
provide better user experience
Issue
#1125 #1305
Checklist
Please delete options that are not relevant.