Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app release process): enhance add technical user process #1401

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Dec 12, 2024

Description

enhance user experience by providing table and overlay in add technical user flow. List current users in the table. Allow user to edit the list in an overlay implementation

Chnagelog

Technical Integration - App and Service Release Process
- enhance user experience by providing table and overlay in add technical user flow. list current users in the table. allow user to edit the list in an overlay implementation [#1401]

Why

provide better user experience

Issue

#1125 #1305

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@manojava-gk manojava-gk marked this pull request as ready for review December 12, 2024 07:32
@manojava-gk manojava-gk added this to the Release 25.03 milestone Dec 12, 2024
searchPlaceholder={''}
columnHeadersBackgroundColor={'#FFFFFF'}
searchDebounce={1000}
noRowsMsg={'No tech user added'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use translations instead of hardcoded text

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Contributor

@lavanya-bmw lavanya-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@kunalgaurav-bmw kunalgaurav-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.

@evegufy
Copy link
Contributor

evegufy commented Dec 13, 2024

@saadanzari @Cofinity-UX would you also like to review?

@Cofinity-UX
Copy link

@evegufy yes, I'd like to review, thanks for looping me in!

@Cofinity-UX
Copy link

Cofinity-UX commented Jan 3, 2025

Hi @manojava-gk,
here are some points for improving the UX (see screenshot for reference). I'm available to do a quick call, if anything is unclear.

1. Copywriting for headline:
"Create technical user" (aligns with wording of CTA on main page)

2. Copywriting for subline
"Please provide the requested information to create a new technical user. Your description helps you easily identify different technical users." (simplified and on point)

3. Inputfiel label wording improvement
"Technical user name"/"Description of technical user"

4. Placeholder text improvement
"Enter technical user name"/"Enter technical user description"

5. Technical user option should not be initially pre-seclected
It's not defined which technical user is preferred by the user

6. Display 'External technical user' first
If it's not possible to display the technical user options after selecting the radio button, 'External technical user' should be displayed as first item, else it will be blocked out of the viewport. Users should see both options initially

7. Harmonize font sizes
Font size of description of Internal/External technical user should have the same font size (reference size: External technical user)

8. Disabled/inactive text should be styled completely as disabled
Inactive options in the Internal technical user section should be completely styled as disabled (description of technical users have still active styling)

9. Checkbox for External technical user option
Identity Wallet Management Technical user should have a checkbox instead of radio button. Since there is only one option: When External technical user is selected, the checkbox for Identity Wallet Management can be preselect

UXreview_technicalusercreation ed._

@manojava-gk
Copy link
Contributor Author

Create technical user

Hi @Cofinity-UX you are looking at a different screen here. This PR is about technical integration step in app/service release process. The screen that you have shared here is from Technical User page. Will address the points which are valid in the current PR

Screenshot 2025-01-03 at 4 36 51 PM Screenshot 2025-01-03 at 4 46 49 PM

Here is the detailed response,

  1. PFA
  2. PFA
  3. NA
  4. NA
  5. Already addressed
  6. Updated - PFA
  7. Already addressed
  8. Updated - PFA
  9. In the ticket it is mentioned to create external roles as radio button. Ticket

@Cofinity-UX
Copy link

@manojava-gk ah, alright, thank you for the clarification!

Copy link

sonarqubecloud bot commented Jan 8, 2025

@manojava-gk
Copy link
Contributor Author

@oyo Any review comments for this?

@oyo oyo merged commit 1177eb4 into eclipse-tractusx:main Jan 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

6 participants