Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add deployment script for local deployment #469

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Jun 20, 2024

Description

The following changes have been made:

  • backend + chart: replace health controller by spring actuator plugin
  • updated chart probes for backend: use a startup probe with better fitting defaults
  • local deployment
    • update generate keys:
      • fixed wrong parameters for keycloak miw_client (not sure why it worked without the script but not with the script)
      • write keys to bruno environment (renamed to local)
    • add local/package.json to use the bruno cli to seed the int test data, if wanted
    • add deploy.sh which provides one-line deployments for common scenarios (full clean, only clean and create puris and direct direct dependencies, also seed int test data)
    • added container that allows to externalize service names to your dns (dns-host-resolver)
    • added healthchecks for nearly all services (needed by deploy.sh)
  • postman: add 25 seconds waiting period after mad tests so that the backend may create the submodel descriptors and tests can be run fully automated.
  • Ci changes:
    • kics should exclude the openApi and the local folder
    • trufflehog shall ignore README.md files

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@tom-rm-meyer-ISST tom-rm-meyer-ISST marked this pull request as ready for review June 20, 2024 07:54
@tom-rm-meyer-ISST
Copy link
Contributor Author

@eschrewe please already review this PR.

I'll meanwhile will work on the worfklow in pr #450 to not enforce the update of the version as we sometimes want to bundle the chart changes for one release and not release every change directly.

@tom-rm-meyer-ISST tom-rm-meyer-ISST force-pushed the refactor/local-deployment branch from 427a3a2 to 020af38 Compare February 21, 2025 12:38
@tom-rm-meyer-ISST tom-rm-meyer-ISST force-pushed the refactor/local-deployment branch from 020af38 to 671534a Compare February 21, 2025 12:40
@tom-rm-meyer-ISST tom-rm-meyer-ISST removed the request for review from eschrewe February 21, 2025 12:42
@tom-rm-meyer-ISST tom-rm-meyer-ISST force-pushed the refactor/local-deployment branch 4 times, most recently from b5ccf25 to fa885eb Compare February 21, 2025 14:05
@tom-rm-meyer-ISST tom-rm-meyer-ISST force-pushed the refactor/local-deployment branch from fa885eb to c6a01e8 Compare February 21, 2025 14:09
@tom-rm-meyer-ISST
Copy link
Contributor Author

tom-rm-meyer-ISST commented Feb 21, 2025

Two things to consider:

  • 1kloc limit is not applicable to committers.
  • Helm chart fails due to version not increased (will be done during release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant