Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: days of supply frontend #776

Merged
merged 6 commits into from
Feb 18, 2025
Merged

feat: days of supply frontend #776

merged 6 commits into from
Feb 18, 2025

Conversation

ReneSchroederLJ
Copy link
Member

@ReneSchroederLJ ReneSchroederLJ commented Feb 14, 2025 •
edited
Loading

Description

  • implemented days of supply in the Material Details View

resolves #311

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Please check the comments.

tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change left, thenn I'll merge. As discussed, we need further discuss timezones in future

tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, helm version to be updated during release

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 30c17ef into eclipse-tractusx:main Feb 18, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Days of Supply - Dashboard integration
2 participants
@ReneSchroederLJ @tom-rm-meyer-ISST