Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removal of unwanted secrets #173

Merged
merged 4 commits into from
Jun 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions INSTALL.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,6 @@ How to install application using helm: <br />
These secrets should be defined in Hashicorp vault to keep them secure.
secret:
jwkSetUri: -> JWK Set URL
clientId: -> Custodian wallet client id
clientSecret: -> Custodian wallet client secret
authServerUrl: -> Keycloak URL
realm: -> Keycloak Realm
resource: -> Keycloak Resource
custodianWalletUri: -> Custodian wallet URI
clearingHouseUri: -> Clearing House URI
clearingHouseServerUrl: -> Clearing House server URL
clearingHouseRealm: -> Realm for Clearing House
Expand Down
8 changes: 1 addition & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ further processing.

```shell
Software version: 2.1.12
Helm Chart version: 2.1.18
Helm Chart version: 2.1.20
```


Expand Down Expand Up @@ -173,12 +173,6 @@ app:
durationDays: 90
schema2210Url: <SCHEMA2210URL>
usersDetails:
custodianWallet:
#uri: https://<example.com>/api
#serverUrl: https://<example.com>/auth
#realm: <REALM>
#clientId: <CLIENTID>
#clientSecret:
clearingHouse:
#uri: https://<example.com>/api/credentials
#serverUrl: https://<example.com>/auth
Expand Down
2 changes: 1 addition & 1 deletion charts/sdfactory/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ sources:
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)

version: "2.1.19"
version: "2.1.20"

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
8 changes: 1 addition & 7 deletions charts/sdfactory/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# sdfactory

![Version: 2.1.19](https://img.shields.io/badge/Version-2.1.19-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.1.12](https://img.shields.io/badge/AppVersion-2.1.12-informational?style=flat-square)
![Version: 2.1.20](https://img.shields.io/badge/Version-2.1.20-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.1.12](https://img.shields.io/badge/AppVersion-2.1.12-informational?style=flat-square)

Helm Charts for SD Factory application. Self-Description Factory component is responsible for the creation of Self Descriptions.

Expand Down Expand Up @@ -42,18 +42,12 @@ Helm Charts for SD Factory application. Self-Description Factory component is re
| resources.limits.memory | string | `"700Mi"` | set a maximum amount of allows memory utilization by specifying a limit on the container. |
| resources.requests.cpu | string | `"300m"` | sets the minimum amount of CPU required for the container |
| resources.requests.memory | string | `"700Mi"` | set a minimum amount of allows memory utilization by specifying a limit on the container. |
| sdfactory.secret.authServerUrl | string | `""` | Keycloak URL |
| sdfactory.secret.clearingHouseClientId | string | `""` | Details for Clearing House Client ID |
| sdfactory.secret.clearingHouseClientSecret | string | `""` | Details for Clearing House Client Secret |
| sdfactory.secret.clearingHouseRealm | string | `""` | Details for Clearing House Realm |
| sdfactory.secret.clearingHouseServerUrl | string | `""` | Details for Clearing House URL |
| sdfactory.secret.clearingHouseUri | string | `""` | Details for Clearing House URI |
| sdfactory.secret.clientId | string | `""` | Custodian wallet client id |
| sdfactory.secret.clientSecret | string | `""` | Custodian wallet client secret |
| sdfactory.secret.custodianWalletUri | string | `""` | Details for Custodian wallet URI |
| sdfactory.secret.jwkSetUri | string | `""` | JWK Set URI |
| sdfactory.secret.realm | string | `""` | Keycloak Realm detail |
| sdfactory.secret.resource | string | `""` | Keycloak Resource detail |
| sdfactory.secret.verifycredentialsUri | string | `""` | Details for Verifying Client uri |
| securityContext.allowPrivilegeEscalation | bool | `false` | |
| securityContext.capabilities.drop[0] | string | `"ALL"` | |
Expand Down
25 changes: 0 additions & 25 deletions charts/sdfactory/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,31 +63,6 @@ spec:
secretKeyRef:
name: {{ include "sdfactory.applicationSecret.name" . }}
key: jwk-set-uri
- name: APP_USERSDETAILS_CUSTODIANWALLET_CLIENTID
valueFrom:
secretKeyRef:
name: {{ include "sdfactory.applicationSecret.name" . }}
key: ClientID
- name: APP_USERSDETAILS_CUSTODIANWALLET_CLIENTSECRET
valueFrom:
secretKeyRef:
name: {{ include "sdfactory.applicationSecret.name" . }}
key: ClientSecret
- name: APP_USERSDETAILS_CUSTODIANWALLET_SERVERURL
valueFrom:
secretKeyRef:
name: {{ include "sdfactory.applicationSecret.name" . }}
key: auth-server-url
- name: APP_USERSDETAILS_CUSTODIANWALLET_URI
valueFrom:
secretKeyRef:
name: {{ include "sdfactory.applicationSecret.name" . }}
key: custodianWalletUri
- name: APP_USERSDETAILS_CUSTODIANWALLET_REALM
valueFrom:
secretKeyRef:
name: {{ include "sdfactory.applicationSecret.name" . }}
key: realm
- name: APP_USERSDETAILS_CLEARINGHOUSE_URI
valueFrom:
secretKeyRef:
Expand Down
6 changes: 0 additions & 6 deletions charts/sdfactory/templates/secret.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,6 @@ metadata:
type: Opaque
stringData:
jwk-set-uri: {{ .Values.sdfactory.secret.jwkSetUri | default "https://jwk-set-uri" }}
ClientID: {{ .Values.sdfactory.secret.clientId | default (randAlphaNum 16) }}
ClientSecret: {{ .Values.sdfactory.secret.clientSecret | default (randAlphaNum 16) }}
auth-server-url: {{ .Values.sdfactory.secret.authServerUrl | default "https://auth" }}
realm: {{ .Values.sdfactory.secret.realm | default (printf "%s-%s" "realm" (randAlpha 6)) }}
resource: {{ .Values.sdfactory.secret.resource | default (printf "%s-%s" "resource" (randAlpha 5)) }}
custodianWalletUri: {{ .Values.sdfactory.secret.custodianWalletUri | default "https://custodianWalletUri" }}
clearingHouse-uri: {{ .Values.sdfactory.secret.clearingHouseUri | default "https://clearingHouse-uri" }}
clearingHouse-serverUrl: {{ .Values.sdfactory.secret.clearingHouseServerUrl | default "https://clearingHouse-serverUrl" }}
clearingHouse-realm: {{ .Values.sdfactory.secret.clearingHouseRealm | default (printf "%s-%s" "realm" (randAlpha 6)) }}
Expand Down
6 changes: 0 additions & 6 deletions charts/sdfactory/values-beta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,6 @@ ingress:
sdfactory:
secret:
jwkSetUri: "<path:essential-services/data/custodian-beta#jwkSetUri>"
clientId: "<path:essential-services/data/custodian-beta#clientId>"
clientSecret: "<path:essential-services/data/custodian-beta#clientSecret>"
authServerUrl: "<path:essential-services/data/custodian-beta#auth-server-url>"
realm: "<path:essential-services/data/custodian-beta#realm>"
resource: "<path:essential-services/data/custodian-beta#resource>"
custodianWalletUri: "<path:essential-services/data/custodian-beta#uri>"
clearingHouseUri: "<path:essential-services/data/custodian-beta#clearingHouse-uri>"
clearingHouseServerUrl: "<path:essential-services/data/custodian-beta#clearingHouse-serverUrl>"
clearingHouseRealm: "<path:essential-services/data/custodian-beta#clearingHouse-realm>"
Expand Down
6 changes: 0 additions & 6 deletions charts/sdfactory/values-dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,6 @@ ingress:
sdfactory:
secret:
jwkSetUri: "<path:essential-services/data/custodian-dev#jwkSetUri>"
clientId: "<path:essential-services/data/custodian-dev#clientId>"
clientSecret: "<path:essential-services/data/custodian-dev#clientSecret>"
authServerUrl: "<path:essential-services/data/custodian-dev#auth-server-url>"
realm: "<path:essential-services/data/custodian-dev#realm>"
resource: "<path:essential-services/data/custodian-dev#resource>"
custodianWalletUri: "<path:essential-services/data/custodian-dev#uri>"
clearingHouseUri: "<path:essential-services/data/custodian-dev#clearingHouse-uri>"
clearingHouseServerUrl: "<path:essential-services/data/custodian-dev#clearingHouse-serverUrl>"
clearingHouseRealm: "<path:essential-services/data/custodian-dev#clearingHouse-realm>"
Expand Down
6 changes: 0 additions & 6 deletions charts/sdfactory/values-int.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,6 @@ ingress:
sdfactory:
secret:
jwkSetUri: "<path:essential-services/data/custodian#jwkSetUri>"
clientId: "<path:essential-services/data/custodian#clientId>"
clientSecret: "<path:essential-services/data/custodian#clientSecret>"
authServerUrl: "<path:essential-services/data/custodian#auth-server-url>"
realm: "<path:essential-services/data/custodian#realm>"
resource: "<path:essential-services/data/custodian#resource>"
custodianWalletUri: "<path:essential-services/data/custodian#uri>"
clearingHouseUri: "<path:essential-services/data/custodian#clearingHouse-uri>"
clearingHouseServerUrl: "<path:essential-services/data/custodian#clearingHouse-serverUrl>"
clearingHouseRealm: "<path:essential-services/data/custodian#clearingHouse-realm>"
Expand Down
6 changes: 0 additions & 6 deletions charts/sdfactory/values-pen.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,6 @@ ingress:
sdfactory:
secret:
jwkSetUri: "<path:essential-services/data/custodian-pen#jwkSetUri>"
clientId: "<path:essential-services/data/custodian-pen#clientId>"
clientSecret: "<path:essential-services/data/custodian-pen#clientSecret>"
authServerUrl: "<path:essential-services/data/custodian-pen#auth-server-url>"
realm: "<path:essential-services/data/custodian-pen#realm>"
resource: "<path:essential-services/data/custodian-pen#resource>"
custodianWalletUri: "<path:essential-services/data/custodian-pen#uri>"
clearingHouseUri: "<path:essential-services/data/custodian-pen#clearingHouse-uri>"
clearingHouseServerUrl: "<path:essential-services/data/custodian-pen#clearingHouse-serverUrl>"
clearingHouseRealm: "<path:essential-services/data/custodian-pen#clearingHouse-realm>"
Expand Down
6 changes: 0 additions & 6 deletions charts/sdfactory/values-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,6 @@ service:
sdfactory:
secret:
jwkSetUri: "<path:essential-services/data/custodian#jwkSetUri>"
clientId: "<path:essential-services/data/custodian#clientId>"
clientSecret: "<path:essential-services/data/custodian#clientSecret>"
authServerUrl: "<path:essential-services/data/custodian#auth-server-url>"
realm: "<path:essential-services/data/custodian#realm>"
resource: "<path:essential-services/data/custodian#resource>"
custodianWalletUri: "<path:essential-services/data/custodian#uri>"
clearingHouseUri: "<path:essential-services/data/custodian#clearingHouse-uri>"
clearingHouseServerUrl: "<path:essential-services/data/custodian#clearingHouse-serverUrl>"
clearingHouseRealm: "<path:essential-services/data/custodian#clearingHouse-realm>"
Expand Down
12 changes: 0 additions & 12 deletions charts/sdfactory/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,18 +65,6 @@ sdfactory:
secret:
# -- JWK Set URI
jwkSetUri: ""
# -- Custodian wallet client id
clientId: ""
# -- Custodian wallet client secret
clientSecret: ""
# -- Keycloak URL
authServerUrl: ""
# -- Keycloak Realm detail
realm: ""
# -- Keycloak Resource detail
resource: ""
# -- Details for Custodian wallet URI
custodianWalletUri: ""
# -- Details for Clearing House URI
clearingHouseUri: ""
# -- Details for Clearing House URL
Expand Down