Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document parallel testing changes (fixes #342) #402

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

Bananeweizen
Copy link
Contributor

No description provided.

@mickaelistria
Copy link
Contributor

+1 for updating the doc.
However, on the long run, you may want to add some option to the TestMojo to prevent it from running parallel executions.

@github-actions
Copy link

github-actions bot commented Nov 29, 2021

Unit Test Results

142 files  142 suites   41m 33s ⏱️
223 tests 220 ✔️ 3 💤 0

Results for commit b5aa568.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member

laeubi commented Nov 30, 2021

Isn't there already a flag (useUIHarness) for UI tests that might be used here?

@mickaelistria
Copy link
Contributor

UI tests usually can execute in parallel. It's more some specific tests or frameworks that require to have the window active. Bit tests can usually have other "locks", eg a DB, that can apply.
So useUIHarness doesn't fit as it's not fine-grain enough. I imagine maven-surefire-plugin may have some capabilities about it that Tycho could consume.

@Bananeweizen
Copy link
Contributor Author

Using that flag seems reasonable on first glance. However, you can also run SWTBot tests just to have thread-safe access to controls, without ever using the "click" features etc. Such tests would be fine. Also, I'm not a linux expert, but I would expect to be able to use different virtual screens there where parallel execution would be okay. That's why I would go for something more explicit (which would also be more easy to find in the documentation then).

@Bananeweizen
Copy link
Contributor Author

BTW: Is there some description available for how you committers generally work? Since I had no negative feedback about this PR and since it passed tests, I would now merge it. Or are self-merges of own PRs not okay?

@laeubi
Copy link
Member

laeubi commented Nov 30, 2021

I would then rather not add any options here but let either

  • disable parallel execution for such test
  • enhance the framework / or use "safe" variants (especially for SWT bot you can construct a bot that only works on a specific window regardless of "active" window)
  • use some other kind of synchronization (e.g. lockfiles or similar)

@laeubi
Copy link
Member

laeubi commented Nov 30, 2021

BTW: Is there some description available for how you committers generally work? Since I had no negative feedback about this PR and since it passed tests, I would now merge it. Or are self-merges of own PRs not okay?

If you are certain that your change is small enough without getting any feedback from others you can merge it, otherwise you can always request a review on it.

@Bananeweizen Bananeweizen merged commit b5aa568 into eclipse-tycho:master Nov 30, 2021
@Bananeweizen Bananeweizen deleted the patch-2 branch November 30, 2021 07:16
@laeubi laeubi added this to the 2.6 milestone Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants