Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #460 Delay classpath resolution to the compile phase #461

Merged
merged 3 commits into from
Dec 31, 2021

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Dec 31, 2021

Signed-off-by: Christoph Läubrich [email protected]

@laeubi laeubi requested a review from mickaelistria December 31, 2021 08:26
@laeubi
Copy link
Member Author

laeubi commented Dec 31, 2021

Example output that shows that classpath resolution is delayed until compile phase:

[INFO] ---------------------------[ eclipse-plugin ]---------------------------
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ tycho.bundle ---
[INFO] Deleting /home/christoph/git/laeubi/tycho/tycho-its/projects/mixed.reactor/tycho.bundle/target
[INFO] 
[INFO] --- tycho-packaging-plugin:2.6.0-SNAPSHOT:build-qualifier (default-build-qualifier) @ tycho.bundle ---
[INFO] The project's OSGi version is 1.0.0.202112310830
[INFO] 
[INFO] --- tycho-packaging-plugin:2.6.0-SNAPSHOT:validate-id (default-validate-id) @ tycho.bundle ---
[INFO] 
[INFO] --- tycho-packaging-plugin:2.6.0-SNAPSHOT:validate-version (default-validate-version) @ tycho.bundle ---
[INFO] 
[INFO] --- target-platform-configuration:2.6.0-SNAPSHOT:target-platform (default-target-platform) @ tycho.bundle ---
[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ tycho.bundle ---
[INFO] skip non existing resourceDirectory /home/christoph/git/laeubi/tycho/tycho-its/projects/mixed.reactor/tycho.bundle/src/main/resources
[INFO] 
[INFO] --- tycho-compiler-plugin:2.6.0-SNAPSHOT:compile (default-compile) @ tycho.bundle ---
[INFO] Resolving class path of tycho.bundle...

@github-actions
Copy link

github-actions bot commented Dec 31, 2021

Unit Test Results

142 files  142 suites   34m 59s ⏱️
224 tests 221 ✔️ 3 💤 0

Results for commit 4980ba6.

♻️ This comment has been updated with latest results.

Signed-off-by: Christoph Läubrich <[email protected]>
@laeubi
Copy link
Member Author

laeubi commented Dec 31, 2021

I have added a validate-classpath mojo just in case one want to still perform the class-path-computation in the verify phase.
This change also proofs that the additional resolving via the Equinox Resolver is only necessary for classpath computation and not for project order.

@laeubi laeubi merged commit 4980ba6 into eclipse-tycho:master Dec 31, 2021
@laeubi laeubi added this to the 2.7 milestone Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant