Speedup Local-Non-Local Context's data operations #5125
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing 3 performance problems:
synchronized
on existing maps (now that biased locking is gone)default
subptimal implement ones, insteadThis PR is pushing improvement furthers, but leveraging the facts that:
ConcurentHasMap
constructor doesn't initialize the internal table, making very cheap to allocate onesynchronized
and just usecompareAndSet
saving another strong memory barrier (in x86, but likely the same in ARM), speeding up common use cases