Fix potential type size mismatch through pointers #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rettichschnidi please review. |
Closed
sbertin-telular
force-pushed
the
fix_249
branch
from
d0aac3c to
fd24cf8
Compare
|
Rebased |
| uint32_t option_number = 0; | ||
| uint32_t option_delta = 0; | ||
| uint32_t option_length = 0; | ||
| uint32_t *x; |
There was a problem hiding this comment.
The casts on line 699 should to be adjusted too.
Rest is looking good to me.
sbertin-telular
force-pushed
the
fix_249
branch
from
fd24cf8 to
a78ab63
Compare
|
Amended to fix casts |
|
Wait a minute, the casts shouldn't be necessary now. |
size_t can be 64-bits while unsigned int is smaller. This causes issues when option_length is accessed through the pointer x in coap_parse_message(). The option length and delta are at most a 16-bit unsigned integer plus 269 according to RFC 7252. Changing option_number, option_delta, and option_length to uint32_t and x to uint32_t * fixes eclipse-wakaama#429. This also ensures sufficient size even if used on a platform with smaller integers. Signed-off-by: Scott Bertin <[email protected]>
sbertin-telular
force-pushed
the
fix_249
branch
from
a78ab63 to
6094b1e
Compare
|
Amended to remove unnecessary type casts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
size_t can be 64-bits while unsigned int is smaller. This causes issues
when option_length is accessed through the pointer x in
coap_parse_message(). The option length and delta are at most a 16-bit
unsigned integer plus 269 according to RFC 7252. Changing
option_number, option_delta, and option_length to uint32_t and x to
uint32_t * fixes #429. This also ensures sufficient size even if used
on a platform with smaller integers.
Signed-off-by: Scott Bertin [email protected]