-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lw/safer string functions #841
Open
LukasWoodtli
wants to merge
2
commits into
eclipse-wakaama:main
Choose a base branch
from
husqvarnagroup:lw/safer_string_functions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lw/safer string functions #841
LukasWoodtli
wants to merge
2
commits into
eclipse-wakaama:main
from
husqvarnagroup:lw/safer_string_functions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasWoodtli
force-pushed
the
lw/safer_string_functions
branch
from
January 4, 2025 19:55
2bc2b38
to
9b53e31
Compare
LukasWoodtli
force-pushed
the
lw/safer_string_functions
branch
3 times, most recently
from
January 4, 2025 20:39
13e8a3d
to
f9ae166
Compare
LukasWoodtli
force-pushed
the
lw/safer_string_functions
branch
3 times, most recently
from
January 4, 2025 21:48
11a2254
to
89c061d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick, initial feedback. Will do a more thorough review once I can spare some time.
LukasWoodtli
force-pushed
the
lw/safer_string_functions
branch
2 times, most recently
from
January 8, 2025 17:06
7dbfaec
to
b4304de
Compare
The function searches for the terminating `NULL` character in the given string up to a given maximun length.
The function checks for source and destination lengths provided.
LukasWoodtli
force-pushed
the
lw/safer_string_functions
branch
from
January 8, 2025 17:14
b4304de
to
8e0b0f7
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide safer variants of
strnlen
andstrncpy
which check the provided bounds of the char arrays.