Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore log workspace dependency #55

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

fuzzypixelz
Copy link
Member

Following #49, the log dependency was replaced by tracing, but log is actually still used by rosrust. The build fails without this.

@fuzzypixelz fuzzypixelz changed the title fix: Restore log workspace dependency fix: Restore log workspace dependency Apr 17, 2024
@gabrik
Copy link
Contributor

gabrik commented Apr 17, 2024

@yellowhatter can you migrate rosrust to tracing?

@fuzzypixelz fuzzypixelz force-pushed the fix/missing-log-dep branch from e7d3858 to 8997c89 Compare April 19, 2024 08:49
Copy link
Contributor

@gabrik gabrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrik gabrik merged commit b5a7811 into eclipse-zenoh:main Apr 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants