Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scorched earth 2 #184

Merged
merged 50 commits into from
Jun 10, 2024
Merged

Scorched earth 2 #184

merged 50 commits into from
Jun 10, 2024

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Apr 18, 2024

Complete rewriting using only Rust code (and Python stub)

@evshary evshary mentioned this pull request Apr 19, 2024
Closed
evshary
evshary suggested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@evshary evshary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to fix the conflict first.

src/session.rs Show resolved Hide resolved
src/queryable.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/config.rs Show resolved Hide resolved
zenoh/__init__.py Show resolved Hide resolved
src/value.rs Show resolved Hide resolved
src/handlers.rs Show resolved Hide resolved
@wyfo
Copy link
Contributor Author

wyfo commented Apr 22, 2024

@evshary I've updated the years because it has been rewritten from scratch, so I think it's pertinent.

@wyfo wyfo force-pushed the scorched_earth_2 branch from ab1152c to 5defb25 Compare April 25, 2024 11:06
wyfo and others added 21 commits April 25, 2024 16:47
@wyfo
chore: bump pyo3 to 0.21 (eclipse-zenoh#175)
a202d14 
Roughly adapt the code to the new PyO3 API, with a few warning fixes.
@wyfo
fix(examples): fix commented parts of z_put.py (eclipse-zenoh#176)
b4733bf 
* fix(examples): fix commented parts of z_put.py

* fix: apply PR reviews

* fix: apply PR reviews
@YuanYuYuan @wyfo
Correct the syntax of pyproject.toml (eclipse-zenoh#181)
67f40f2
@fuzzypixelz @wyfo
feat: Automate Release (eclipse-zenoh#165)
05faf5d 
* build: Get Read the Docs release number from Cargo manifest

This avoids hardcoding the release number in the documentation build config,
making it easier to bump the version by only modifying the manifest.

* build: Require Python 3.11 in Read the Docs configuration

Python 3.11 is needed to access tomllib; useful for parsing the Cargo manifest file.

* feat: Create branch, bump version and tag in release workflow

* feat: Add publish-github job

* fix: Broken tag dependencies

* chore: Remove enforce-linking-issues workflow

* fix: Bump version in pyproject.toml

* chore: Upgrade artifact actions from v3 to v4

* fix: Typo in git-commit command

* fix: Support jq 1.6

ubuntu-22.04 runners use jq 1.6 which doesn't recognize a dot for `[]` value iterator.

See: jqlang/jq#1168.

* Revert "chore: Upgrade artifact actions from v3 to v4"

This reverts commit a535971.

* fix: Build wheels from release branch

* fix: Switch to pypa/gh-action-pypi-publish@release/v1

The older actions doesn't recognize the pyproject.toml metadata fields.
@wyfo
refactor: scorched earth 2! ;)
bd35e15 
Complete rewriting using only Rust code (and Python stub)
@wyfo
chore: add copyright header
05ff0ed
@wyfo
feat: release GIL in Drop implementations
fbccae9 
See eclipse-zenoh#180
@wyfo
fix: don't use enum for encoding stub
7df353b
@wyfo
refactor: prepare async resolve
e0123b2
@wyfo
fix: fix constructors accepting Self type, use extractors instead
617bfdd
@wyfo
refactor: move everything in root Python module
270e83d
@wyfo
feat: convert Python stub to generate doc
087e106
@wyfo
refactor: make handler a positional/keyword argument
f17910d
@wyfo
fix: fix __eq__ bug caused by a PyO3 bug
db3184c 
see PyO3/pyo3#4113
@wyfo
feat: add __repr__ for every type
ea37d98
@wyfo
feat: add Parameters API
361333c
@wyfo
fix: replace Payload by ZBytes
9fe9706
@wyfo
feat: use weak reference to session for SessionInfo
67297a8
@wyfo
fix: add missing stub for parameters
ec6d6e5
@wyfo
fix: fix tests
63be0f0
@wyfo
chore: delete .rustfmt.toml as long as it's not supported by the CI
433907f
@wyfo wyfo force-pushed the scorched_earth_2 branch from 2fcc34f to 0353934 Compare April 25, 2024 14:48
@wyfo
Copy link
Contributor Author

wyfo commented Apr 25, 2024

The doc rendition is not good, because it doesn't seem to take in account the change that I made in .readthedocs.yml. I've tested it on my side, and it works fine.

@wyfo wyfo force-pushed the scorched_earth_2 branch from 0353934 to 53fa3d7 Compare April 25, 2024 14:52
@wyfo
Copy link
Contributor Author

wyfo commented Apr 25, 2024 •
edited
Loading

Tests doesn't pass because it seems I've resolved a bug, which was taken in account in the tests. In fact, some tests was not able to be stopped with SIGINT, and required to be killed.
~~It's no more the case with this PR~It's still the case with this PR. I've spent one hour trying to determine what was the cause of this bug on main, but I'm ashamed to admit I failed; I don't know what is causing this kind of deadlocks in the tests.
Anyway, I should update the tests to not expect programs to be killed.
@evshary If you have information about this, I would be very interested.

@wyfo
Copy link
Contributor Author

wyfo commented May 6, 2024

The tests doesn't pass yet because of the deadlock issue in the examples. It's caused by relying on pseudo-RAII while exiting tests with an exception, which causes finalizers to run while Python interpreter is shutting down.
Solving this issue requires an important discussion about RAII use, so for now, the tests aren't touched.

@fuzzypixelz
Copy link
Member

@wyfo Please change the base branch to dev/1.0.0 as protocol_changes is no longer the development branch.

@wyfo wyfo changed the base branch from protocol_changes to dev/1.0.0 May 17, 2024 10:25
@wyfo wyfo mentioned this pull request May 17, 2024
Closed
@wyfo wyfo force-pushed the scorched_earth_2 branch from 7c5e489 to e02acc9 Compare June 3, 2024 16:05
@milyin milyin merged commit 17c66ad into eclipse-zenoh:dev/1.0.0 Jun 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets left review comments

@evshary evshary evshary requested changes

Assignees
No one assigned
Labels
None yet
Projects
Zenoh 1.0.0 release
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wyfo @fuzzypixelz @evshary @Mallets @milyin @YuanYuYuan