Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zenohd default config error #1292

Open
Sobczaczek opened this issue Aug 2, 2024 · 3 comments
Open

zenohd default config error #1292

Sobczaczek opened this issue Aug 2, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Sobczaczek
Copy link

Describe the bug

While running zenohd with default (DEFAULT_CONFIG.json5) config -> error:
INFO main ThreadId(01) zenohd: zenohd v1.0.0-alpha.5 built with rustc 1.75.0 (82e1608df 2023-12-21)
thread 'main' panicked at zenohd/src/main.rs:122:42:
called Result::unwrap() on an Err value: JSON error: invalid type: string "", expected a list of whatami variants ('router', 'peer', 'client') at commons/zenoh-config/src/lib.rs:748.
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

To reproduce

  1. zenohd -c DEFAULT_CONFIG.json5

System info

  • Ubuntu 24.04
@Sobczaczek Sobczaczek added the bug Something isn't working label Aug 2, 2024
@anhaabaete
Copy link
Contributor

Please, test it.

main...anhaabaete:zenoh:patch-1

it work to me.

anhaabaete added a commit to anhaabaete/zenoh that referenced this issue Aug 5, 2024
@anhaabaete
zenohd default config error eclipse-zenoh#1292
d193856 
When tring load config file defined by -c option. With haver any problema "unwrap" has been to Config type.

I treat it return a Default Config whe it happen
@anhaabaete anhaabaete mentioned this issue Aug 5, 2024
Merged
@Sobczaczek
Copy link
Author

@anhaabaete thank you, it works

gabrik pushed a commit that referenced this issue Aug 12, 2024
@anhaabaete
zenohd-default config error #1292 (#1298)
e66745e 
* Zenohd panic when tring load file

When zenohd trying load file, if it have a problem it crash cause another treat was "unwrap", and it return to a type config. So, it crash and cause painic.

* zenohd default config error #1292

When tring load config file defined by -c option. With haver any problema "unwrap" has been to Config type.

I treat it return a Default Config whe it happen

* If file fail when try load configs

If file fail when try load configs

* Update main.rs

* Resolve typos at comment

Resolve typos at comment
milyin pushed a commit that referenced this issue Aug 27, 2024
@anhaabaete @milyin
zenohd-default config error #1292 (#1298)
c817e65 
* Zenohd panic when tring load file

When zenohd trying load file, if it have a problem it crash cause another treat was "unwrap", and it return to a type config. So, it crash and cause painic.

* zenohd default config error #1292

When tring load config file defined by -c option. With haver any problema "unwrap" has been to Config type.

I treat it return a Default Config whe it happen

* If file fail when try load configs

If file fail when try load configs

* Update main.rs

* Resolve typos at comment

Resolve typos at comment
@milyin milyin reopened this Aug 27, 2024
@milyin
Copy link
Contributor

milyin commented Aug 27, 2024

The approach used for fixing this seems to be wrong, we need to correct DEFAULT_CONFIG or provide default value for this parameter. See discussion in #1326
Going to revert the fix

@milyin milyin mentioned this issue Aug 27, 2024
Merged
Mallets added a commit that referenced this issue Aug 27, 2024
@milyin @evshary
@fuzzypixelz @Mallets @kilpkonn @JLerxky @JEnoch @OlivierHecart @YuanYuYuan @diogomatsubara @kydos @brian049 @anhaabaete
Merge main into dev/1.0.0 (#1326)
6f43f95 
* Add NOTE for LowLatency transport. (#1088)

Signed-off-by: ChenYing Kuo <[email protected]>

* fix: Improve debug messages in `zenoh-transport` (#1090)

* fix: Improve debug messages for failing RX/TX tasks

* fix: Improve debug message for `accept_link` timeout

* chore: Fix `clippy::redundant_pattern_matching` error

* Improve pipeline backoff (#1097)

* Yield task for backoff

* Improve comments and error handling in backoff

* Simplify pipeline pull

* Consider backoff configuration

* Add typos check to CI (#1065)

* Fix typos

* Add typos check to CI

* Start link tx_task before notifying router (#1098)

* Fix typos (#1110)

* bump quinn & rustls (#1086)

* bump quinn & rustls

* fix ci windows check

* add comments

* Fix interface name scanning when listening on IP unspecified for TCP/TLS/QUIC/WS (#1123)

Co-authored-by: Julien Enoch <[email protected]>

* Enable releasing from any branch (#1136)

* Fix cargo clippy (#1145)

* Release tables locks before propagating subscribers and queryables declarations to void dead locks (#1150)

* Send simple sub and qabl declarations using a given function

* Send simple sub and qabl declarations after releasing tables lock

* Send simple sub and qabl declarations after releasing tables lock (missing places)

* feat: make `TerminatableTask` terminate itself when dropped (#1151)

* Fix bug in keyexpr::includes leading to call get_unchecked on empty array UB (#1208)

* REST plugin uses unbounded flume channels for queries (#1213)

* fix: typo in selector.rs (#1228)

* fix: zenohd --cfg (#1263)

* fix: zenohd --cfg

* ci: trigger

* Update zenohd/src/main.rs

---------

Co-authored-by: Luca Cominardi <[email protected]>

* Fix failover brokering bug reacting to linkstate changes (#1272)

* Change missleading log

* Fix failover brokering bug reacting to linkstate changes

* Retrigger CI

---------

Co-authored-by: Luca Cominardi <[email protected]>

* Code format

* Fix clippy warnings

* Code format

* Fix Clippy errors from Rust 1.80 (#1273)

* Allow unexpected `doc_auto_cfg` flag

* Keep never-constructed logger interceptor

* Ignore interior mutability of `Resource`

* Fix typo

* Resolve `clippy::doc-lazy-continuation` errors

* Upgrade `[email protected]` to `[email protected]`

See time-rs/time#693

* Update Cargo.toml (#1277)

Updated description to be aligned with what we use everywhere else

* fix: typos (#1297)

* Replace trees computation tasks with a worker (#1303)

* Replace trees computation tasks with a worker

* Address review comments

* Remove review comments

* zenohd-default config error #1292 (#1298)

* Zenohd panic when tring load file

When zenohd trying load file, if it have a problem it crash cause another treat was "unwrap", and it return to a type config. So, it crash and cause painic.

* zenohd default config error #1292

When tring load config file defined by -c option. With haver any problema "unwrap" has been to Config type.

I treat it return a Default Config whe it happen

* If file fail when try load configs

If file fail when try load configs

* Update main.rs

* Resolve typos at comment

Resolve typos at comment

* fix: typos (#1297)

* zenohd-default config error #1292 (#1298)

* Zenohd panic when tring load file

When zenohd trying load file, if it have a problem it crash cause another treat was "unwrap", and it return to a type config. So, it crash and cause painic.

* zenohd default config error #1292

When tring load config file defined by -c option. With haver any problema "unwrap" has been to Config type.

I treat it return a Default Config whe it happen

* If file fail when try load configs

If file fail when try load configs

* Update main.rs

* Resolve typos at comment

Resolve typos at comment

* Replace trees computation tasks with a worker (#1303)

* Replace trees computation tasks with a worker

* Address review comments

* Remove review comments

* revering fix #1298

---------

Signed-off-by: ChenYing Kuo <[email protected]>
Co-authored-by: ChenYing Kuo (CY) <[email protected]>
Co-authored-by: Mahmoud Mazouz <[email protected]>
Co-authored-by: Luca Cominardi <[email protected]>
Co-authored-by: Tavo Annus <[email protected]>
Co-authored-by: JLer <[email protected]>
Co-authored-by: Julien Enoch <[email protected]>
Co-authored-by: OlivierHecart <[email protected]>
Co-authored-by: Yuyuan Yuan <[email protected]>
Co-authored-by: Diogo Matsubara <[email protected]>
Co-authored-by: OlivierHecart <[email protected]>
Co-authored-by: kydos <[email protected]>
Co-authored-by: brianPA <[email protected]>
Co-authored-by: Tiago Neves <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@milyin @anhaabaete @Sobczaczek