Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SHM enabled by default in Config #1312

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

yellowhatter
Copy link
Contributor

No description provided.

@yellowhatter
Copy link
Contributor Author

@Mallets SHM now enabled in the Config
(CI failure is transport_tcp_concurrent on Windows and not related to SHM)

@Mallets
Copy link
Member

Mallets commented Aug 14, 2024

I would add the description

// A probing procedure for shared memory is performed upon session opening. To enable z_pub_shm to operate
// over shared memory (and to not fallback on network mode), shared memory needs to be enabled also on the
// subscriber side. By doing so, the probing procedure will succeed and shared memory will operate as expected.

that is present in the examples to the shared_memory section in the DEFAULT_CONFIG to not lose the information.

@yellowhatter
Copy link
Contributor Author

I would add the description

// A probing procedure for shared memory is performed upon session opening. To enable z_pub_shm to operate
// over shared memory (and to not fallback on network mode), shared memory needs to be enabled also on the
// subscriber side. By doing so, the probing procedure will succeed and shared memory will operate as expected.

that is present in the examples to the shared_memory section in the DEFAULT_CONFIG to not lose the information.

done

zenoh/tests/shm.rs Outdated Show resolved Hide resolved
@Mallets Mallets merged commit 0e2f78a into eclipse-zenoh:dev/1.0.0 Aug 14, 2024
12 checks passed
gmartin82 pushed a commit to ZettaScaleLabs/zenoh that referenced this pull request Aug 19, 2024
* make SHM enabled by default in Config

* [skip ci] add SHM description in the config file

* review fixes: assert -> unwrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants