Fix bug in return_conditions declares leading to wait for the full delay

[OlivierHecart]

No description provided.

[fuzzypixelz]

This is rather tangential but I have a question about a change in #1535:

zenoh/zenoh/src/net/routing/hat/p2p_peer/gossip.rs

Lines 454 to 460 in 3f97bfc

	if self.wait_declares && src_whatami != WhatAmI::Peer {
	zenoh_runtime::ZRuntime::Net.block_in_place(
	strong_runtime
	.start_conditions()
	.terminate_peer_connector_zid(src),
	);
	}

After scouting a router that didn't gossip about any other nodes, we only return in open if open/return_conditions/declares is true. Even though the router sends no initial interest declarations.

I tested with one router and one peer configured with open/return_conditions/declares:false and open/return_conditions/connect_scouted:true. The peer doesn't return from open before the scouting delay. Although AFAICT no declarations are expected from the router anyway.

[OlivierHecart]

This is rather tangential but I have a question about a change in #1535:

zenoh/zenoh/src/net/routing/hat/p2p_peer/gossip.rs

Lines 454 to 460 in 3f97bfc

	if self.wait_declares && src_whatami != WhatAmI::Peer {
	zenoh_runtime::ZRuntime::Net.block_in_place(
	strong_runtime
	.start_conditions()
	.terminate_peer_connector_zid(src),
	);
	}

After scouting a router that didn't gossip about any other nodes, we only return in open if open/return_conditions/declares is true. Even though the router sends no initial interest declarations.

I tested with one router and one peer configured with open/return_conditions/declares:false and open/return_conditions/connect_scouted:true. The peer doesn't return from open before the scouting delay. Although AFAICT no declarations are expected from the router anyway.

This looks indeed wrong. Please check my fix.