refactor(storage-manager): replication log lookup #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method now iterates over both the `SubIntervalIdx` and `SubInterval` instead of only the `SubInterval`. This change will be needed to optimise the `LogLatest::lookup` method. * plugins/zenoh-plugin-storage-manager/src/replication/classification.rs: change the signature of the method `Interval::sub_intervals` to iterate over both the sub-interval index and sub-interval. * plugins/zenoh-plugin-storage-manager/src/replication/core/aligner_query.rs: update due to the change. Signed-off-by: Julien Loudet <[email protected]>
oteffahi
suggested changes
Oct 28, 2024
plugins/zenoh-plugin-storage-manager/src/replication/classification.rs
Outdated
Show resolved
Hide resolved
| if event.timestamp >= event_to_lookup.timestamp { | ||
| EventLookup::NewerOrIdentical(event) | ||
| } else { | ||
| EventLookup::Older |
There was a problem hiding this comment.
Are we sure it will never be useful to get the event in case of an EventLookup::Older?
IMO semantically the event exists, we should return it and it should be up to the calling logic to use it or not (unless this has a significant impact on performance).
There was a problem hiding this comment.
I understand your point of view however as that code is only called from the Replication and that, for now, there are no cases where the metadata of an older event is needed, adding it brings no value (YAGNI).
This commit optimises the method `lookup` to only lookup for newer (and
thus rename it to `lookup_newer`) Event.
As it is only looking for a newer Event, this method skips the Intervals
and SubIntervals that, by construction of the Replication Log, only
contain Events with lower timestamps.
* plugins/zenoh-plugin-storage-manager/src/replication/classification.rs:
- Added new enumeration `EventLookup`.
- Removed the `Interval::lookup` method as this commit made it unneeded.
- Updated the `SubInterval::lookup` method to return the newly created
`EventLookup` enumeration.
* plugins/zenoh-plugin-storage-manager/src/replication/core/aligner_reply.rs:
- Removed the code to filter out an Event with an older timestamp as
the method `LogLatest::lookup_newer` already does it.
- Create the `EventMetadata` before calling `LogLatest::remove_event` to
avoid multiple borrows.
* plugins/zenoh-plugin-storage-manager/src/replication/log.rs: renamed
the method `LogLatest::lookup` to `LogLatest::lookup_newer` and
modified its behaviour to only look for newer Event.
* plugins/zenoh-plugin-storage-manager/src/storages_mgt/service.rs:
only test if `LogLatest::lookup_newer` returned something.
Signed-off-by: Julien Loudet <[email protected]>
J-Loudet
force-pushed
the
refactor/storage-manager/replication-log-lookup
branch
from
32b93d8 to
9b5c1d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit optimises the method
lookupto only lookup for newer (andthus rename it to
lookup_newer) Event.As it is only looking for a newer Event, this method skips the Intervals
and SubIntervals that, by construction of the Replication Log, only
contain Events with lower timestamps.