fix: handle linkstate decoding error #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panicking here was causing a major security breach concerning every non-encrypted transport, especially UDP ones. An attacker could simply forge a invalid OAM linkstate message to make the transport panic. Regarding UDP multicast network, a single message could make the whole network instantly unresponsive.
|
PR missing one of the required labels: {'documentation', 'dependencies', 'new feature', 'bug', 'breaking-change', 'enhancement', 'internal'} |
|
The problem is also present in case of encrypted transports. Besides that LGTM. |
Mallets
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panicking here was causing a major security breach concerning every non-encrypted transport, especially UDP ones. An attacker could simply forge a invalid OAM linkstate message to make the transport panic. Regarding UDP multicast network, a single message could make the whole network instantly unresponsive.