Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storage-manager): improve documentation of Replication #1750

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

J-Loudet
Copy link

Some comments were outdated and some methods, functions had none. This commit fixes these oversights.

Some comments were outdated and some methods, functions had none. This
commit fixes these oversights.

Signed-off-by: Julien Loudet <[email protected]>
@J-Loudet J-Loudet requested a review from oteffahi January 31, 2025 14:06
Copy link

PR missing one of the required labels: {'internal', 'documentation', 'breaking-change', 'dependencies', 'enhancement', 'bug', 'new feature'}

@J-Loudet J-Loudet added the documentation Improvements or additions to documentation label Jan 31, 2025
Copy link
Contributor

@oteffahi oteffahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Mallets Mallets merged commit 732196f into main Feb 3, 2025
26 of 27 checks passed
@Mallets Mallets deleted the docs/storage-manager/replication branch February 3, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants