-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHM lazy init is now configured in config.json #1756
SHM lazy init is now configured in config.json #1756
Conversation
commons/zenoh-config/src/lib.rs
Outdated
/// latency at the first SHM buffer interaction moment. | ||
/// `false` setting sacrifices startup time, but guarantees no latency impact when first SHM buffer is | ||
/// processed. | ||
lazy_init: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the queue, the lazy initialisation is exposed with this configuration structure:
Line 478 in e4ea6f0
allocation: { |
If possible it would be good to adopt a similar structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
It's unclear to me from this PR who the lazy init workflow behaves. Would you mind elaborating it a bit? |
"lazy" was the only behavior of SHM before this PR: initialize SHM internal data and threads on-demand (which means "at first SHM buffer interaction"). This PR adds "init" mode that initializes all SHM stuff at first Session open. From the config doc:
|
Thanks! I thought more things were needed to add the desired behaviour but it's not the case. LGTM I would then simply address the comment on the configuration. |
Adds SHM lazy init behavior control through config
"lazy" was the only behavior of SHM before this PR: initialize SHM internal data and threads on-demand (which means "at first SHM buffer interaction"). This PR adds "init" mode that initializes all SHM stuff at first Session open.
From the config doc: