Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connectivity events #385

Merged
merged 5 commits into from
Dec 6, 2022
Merged

Connectivity events #385

merged 5 commits into from
Dec 6, 2022

Conversation

OlivierHecart
Copy link
Contributor

No description provided.

Mallets
Mallets requested changes Dec 1, 2022
View reviewed changes
Copy link
Member

@Mallets Mallets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging I suggest to add a test (e.g. in zenoh/tests/events.rs) to verify the feature.

@OlivierHecart OlivierHecart requested a review from Mallets December 6, 2022 09:03
@Mallets Mallets merged commit 6ea5275 into master Dec 6, 2022
@Mallets Mallets deleted the connectivity-events branch December 6, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

@JEnoch JEnoch Awaiting requested review from JEnoch

@p-avital p-avital Awaiting requested review from p-avital

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OlivierHecart @Mallets