Liveliness & FetchingSubscriber #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than from Session
|
LGTM. Please add some tests before merging. @p-avital can you also review this PR? |
Mallets
approved these changes
Mar 29, 2023
JEnoch
added a commit
to eclipse-zenoh/zenoh-plugin-dds
that referenced
this pull request
Apr 6, 2023
OlivierHecart
added a commit
to eclipse-zenoh/zenoh-plugin-dds
that referenced
this pull request
Apr 11, 2023
* Use liveliness tokens rather than group management * Update to new liveliness API * Update to new QueryingSubscriber builder * Make the liveliness Subscriber a QueryingSubscriber * Accept Any replies when fetching historical data * Accept Any replies in initial query * Back to zenoh master branch after eclipse-zenoh/zenoh#441 --------- Co-authored-by: Julien Enoch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
builder-devis based on branchliveliness2which is based onliveliness. So if this PR is accepted, PRs #430 and #436 can be aborted and relative branches deleted.I addressed comments from both those PRs except for tests. I believe this could go in another PR.