Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try pkcs8_private_keys if rsa_private_keys doesn't return any keys Resolves #448 #450

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

Tejpbit
Copy link
Contributor

@Tejpbit Tejpbit commented Mar 23, 2023

Trying to resolve this issue
#448

@Tejpbit
Copy link
Contributor Author

Tejpbit commented Mar 23, 2023

I don't get what's failing on the eca check.
I've created an account on account.eclipse.org using the same email i used to create the commit.
And I've signed the eca on that site and then pressed the revalidate button.

@Tejpbit Tejpbit force-pushed the fix_reading_pem_file_issue branch from e48eae5 to 3a0e3c2 Compare March 23, 2023 17:36
@Tejpbit
Copy link
Contributor Author

Tejpbit commented Mar 23, 2023

Added the footer
Signed-off-by: André Samuelsson [email protected]
Didn't seem to help...

@DariusIMP
Copy link
Member

Thanks for your contribution, that indeed should solve the bug :)

@gabrik
Copy link
Contributor

gabrik commented Mar 24, 2023

@Tejpbit thank you for your contribution, apparently, the CI fails on format check.
Can you please run: cargo fmt && cargo clippy --all-targets -- -D warnings && cargo test and commit the changes?
This should ensure that the CI passes.

Thank you!

@Tejpbit Tejpbit force-pushed the fix_reading_pem_file_issue branch from 76ef030 to 0d07d5d Compare March 24, 2023 11:33
@Mallets
Copy link
Member

Mallets commented Mar 27, 2023

I don't get what's failing on the eca check. I've created an account on account.eclipse.org using the same email i used to create the commit. And I've signed the eca on that site and then pressed the revalidate button.

Hello @Tejpbit , have you used this link to validate the ECA? https://accounts.eclipse.org/user/login?destination=legal/eca/validation/146737
I'm not sure how Eclipse's CA would behave if a different link is used...

@gabrik
Copy link
Contributor

gabrik commented Mar 27, 2023

Apparently, the emails do not match, at least this seems to be why ECA validation fails.
Screenshot 2023-03-27 at 12 41 20

Signed-off-by: André Samuelsson <[email protected]>
@Tejpbit Tejpbit force-pushed the fix_reading_pem_file_issue branch from 0d07d5d to ff6ff3f Compare March 27, 2023 13:30
@Tejpbit
Copy link
Contributor Author

Tejpbit commented Mar 27, 2023

I did my last commit with my work email configured...
I amended the commit (and configured the repo to always use my other email if when/if i do commits in the future)
Thanks @gabrik

@Mallets Mallets merged commit 198f9b8 into eclipse-zenoh:master Mar 27, 2023
@Tejpbit Tejpbit deleted the fix_reading_pem_file_issue branch March 27, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants